You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jhgoebbert (via GitHub)" <gi...@apache.org> on 2025/10/05 08:23:21 UTC

Re: [PR] Fix the write-to-es feature [airflow]

jhgoebbert commented on PR #53821:
URL: https://github.com/apache/airflow/pull/53821#issuecomment-3368855949

   In airflow/chart `execution_date` is still referenced https://github.com/apache/airflow/blob/main/chart/values.yaml#L2921
   ```
   log_id_template: "{dag_id}_{task_id}_{execution_date}_{try_number}"
   ```
   which makes ES logging fail if it is deployed with helm with
   ```
     File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/elasticsearch/log/es_task_handler.py", line 585, in upload
       log_id = _render_log_id(self.log_id_template, ti, ti.try_number)  # type: ignore[arg-type]
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/elasticsearch/log/es_task_handler.py", line 112, in _render_log_id
       return log_id_template.format(
              ^^^^^^^^^^^^^^^^^^^^^^^
   KeyError: 'execution_date'
   ```
   Perhaps this could also be fixed in this PR right away.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org