[GitHub] [helix] kaisun2000 commented on a change in pull request #1218: Fix ClusterManager thread leak

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r465922072



##########
File path: helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -155,11 +155,16 @@ private void pollForDoubleAssign() {
    * Randomly causes Participants to lost connection temporarily.
    */
   private void breakConnection() {
+    // Note, send to THREAD_COUNT == 1 is a must to avoid leaking ClusterManager (participant).

Review comment:
       This test relies on randomness. Also, the do not really wait for enough time to do breakConnection() etc. However, if we wait, there will be even a lot more leaking. Let us make an agreement that the design of the test is out of scope of this pull request. First stabilize the test. Will use singleThreadExecutor for now,




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org