You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by mpet <gi...@git.apache.org> on 2016/08/29 11:50:31 UTC
[GitHub] maven-plugins pull request #91: MCHANGES-373
GitHub user mpet opened a pull request:
https://github.com/apache/maven-plugins/pull/91
MCHANGES-373
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mpet/maven-plugins MCHANGES-373
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-plugins/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
Author: mike <mi...@hotmail.com>
Date: 2016-08-29T11:39:24Z
MCHANGES-373
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
Posted by Mikael Petterson <mi...@ericsson.com>.
Hi,
My mistake :-)
Br,
//mikael
-----Original Message-----
From: Benedikt Ritter [mailto:britter@apache.org]
Sent: den 7 september 2016 11:36
To: Maven Developers List <de...@maven.apache.org>
Subject: Re: [GitHub] maven-plugins pull request #91: MCHANGES-373
Hello Mikael,
Michael Osipov has asked two times why the change set shows the whole class as changed. So there has been feedback.
Regards,
Benedikt
Mikael Petterson <mi...@ericsson.com> schrieb am Mi., 7. Sep.
2016 um 08:08 Uhr:
> Hi,
>
> Is there no one that can help out with my pull request or is the
> maven-changes plugin "dead"?
> We really need this fix to be able to use the plugin. And also we want
> to be able to help out.
> It is a bit frustrating when nothing happens....
>
> //mikael
>
>
> -----Original Message-----
> From: Mikael Petterson [mailto:mikael.petterson@ericsson.com]
> Sent: den 5 september 2016 14:48
> To: Maven Developers List <de...@maven.apache.org>
> Subject: RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> Hi,
>
> Just a friendly reminder to review code and if ok commit.
>
> Br,
>
> //mikael
>
> -----Original Message-----
> From: mpet [mailto:git@git.apache.org]
> Sent: den 29 augusti 2016 13:51
> To: dev@maven.apache.org
> Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> GitHub user mpet opened a pull request:
>
> https://github.com/apache/maven-plugins/pull/91
>
> MCHANGES-373
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/mpet/maven-plugins MCHANGES-373
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/maven-plugins/pull/91.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #91
>
> ----
> commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
> Author: mike <mi...@hotmail.com>
> Date: 2016-08-29T11:39:24Z
>
> MCHANGES-373
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have
> your reply appear on GitHub as well. If your project does not have
> this feature enabled and wishes so, or if the feature is enabled but
> not working, please contact infrastructure at
> infrastructure@apache.org or file a JIRA ticket with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [GitHub] maven-plugins pull request #91: MCHANGES-373
Posted by Benedikt Ritter <br...@apache.org>.
Hello Mikael,
Michael Osipov has asked two times why the change set shows the whole class
as changed. So there has been feedback.
Regards,
Benedikt
Mikael Petterson <mi...@ericsson.com> schrieb am Mi., 7. Sep.
2016 um 08:08 Uhr:
> Hi,
>
> Is there no one that can help out with my pull request or is the
> maven-changes plugin "dead"?
> We really need this fix to be able to use the plugin. And also we want to
> be able to help out.
> It is a bit frustrating when nothing happens....
>
> //mikael
>
>
> -----Original Message-----
> From: Mikael Petterson [mailto:mikael.petterson@ericsson.com]
> Sent: den 5 september 2016 14:48
> To: Maven Developers List <de...@maven.apache.org>
> Subject: RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> Hi,
>
> Just a friendly reminder to review code and if ok commit.
>
> Br,
>
> //mikael
>
> -----Original Message-----
> From: mpet [mailto:git@git.apache.org]
> Sent: den 29 augusti 2016 13:51
> To: dev@maven.apache.org
> Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> GitHub user mpet opened a pull request:
>
> https://github.com/apache/maven-plugins/pull/91
>
> MCHANGES-373
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/mpet/maven-plugins MCHANGES-373
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/maven-plugins/pull/91.patch
>
> To close this pull request, make a commit to your master/trunk branch with
> (at least) the following in the commit message:
>
> This closes #91
>
> ----
> commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
> Author: mike <mi...@hotmail.com>
> Date: 2016-08-29T11:39:24Z
>
> MCHANGES-373
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have
> your reply appear on GitHub as well. If your project does not have this
> feature enabled and wishes so, or if the feature is enabled but not
> working, please contact infrastructure at infrastructure@apache.org or
> file a JIRA ticket with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
> commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
> commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [GitHub] maven-plugins pull request #91: MCHANGES-373
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi,
all of the maven committers are doing work on Maven in their spare time...
So it takes as long as it takes...
Kind regards
Karl Heinz Marbaise
On 07/09/16 08:08, Mikael Petterson wrote:
> Hi,
>
> Is there no one that can help out with my pull request or is the maven-changes plugin "dead"?
> We really need this fix to be able to use the plugin. And also we want to be able to help out.
> It is a bit frustrating when nothing happens....
>
> //mikael
>
>
> -----Original Message-----
> From: Mikael Petterson [mailto:mikael.petterson@ericsson.com]
> Sent: den 5 september 2016 14:48
> To: Maven Developers List <de...@maven.apache.org>
> Subject: RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> Hi,
>
> Just a friendly reminder to review code and if ok commit.
>
> Br,
>
> //mikael
>
> -----Original Message-----
> From: mpet [mailto:git@git.apache.org]
> Sent: den 29 augusti 2016 13:51
> To: dev@maven.apache.org
> Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> GitHub user mpet opened a pull request:
>
> https://github.com/apache/maven-plugins/pull/91
>
> MCHANGES-373
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/mpet/maven-plugins MCHANGES-373
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/maven-plugins/pull/91.patch
>
> To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message:
>
> This closes #91
>
> ----
> commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
> Author: mike <mi...@hotmail.com>
> Date: 2016-08-29T11:39:24Z
>
> MCHANGES-373
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA.
> ---
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
Posted by Mikael Petterson <mi...@ericsson.com>.
Hi,
Is there no one that can help out with my pull request or is the maven-changes plugin "dead"?
We really need this fix to be able to use the plugin. And also we want to be able to help out.
It is a bit frustrating when nothing happens....
//mikael
-----Original Message-----
From: Mikael Petterson [mailto:mikael.petterson@ericsson.com]
Sent: den 5 september 2016 14:48
To: Maven Developers List <de...@maven.apache.org>
Subject: RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
Hi,
Just a friendly reminder to review code and if ok commit.
Br,
//mikael
-----Original Message-----
From: mpet [mailto:git@git.apache.org]
Sent: den 29 augusti 2016 13:51
To: dev@maven.apache.org
Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373
GitHub user mpet opened a pull request:
https://github.com/apache/maven-plugins/pull/91
MCHANGES-373
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mpet/maven-plugins MCHANGES-373
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-plugins/pull/91.patch
To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message:
This closes #91
----
commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
Author: mike <mi...@hotmail.com>
Date: 2016-08-29T11:39:24Z
MCHANGES-373
----
---
If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
Posted by Mikael Petterson <mi...@ericsson.com>.
Hi,
Just a friendly reminder to review code and if ok commit.
Br,
//mikael
-----Original Message-----
From: mpet [mailto:git@git.apache.org]
Sent: den 29 augusti 2016 13:51
To: dev@maven.apache.org
Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373
GitHub user mpet opened a pull request:
https://github.com/apache/maven-plugins/pull/91
MCHANGES-373
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mpet/maven-plugins MCHANGES-373
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-plugins/pull/91.patch
To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message:
This closes #91
----
commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
Author: mike <mi...@hotmail.com>
Date: 2016-08-29T11:39:24Z
MCHANGES-373
----
---
If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-plugins pull request #91: MCHANGES-373
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-plugins/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org