You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/05 19:33:01 UTC

[jira] [Commented] (GEODE-8799) Increase default OperationExecutors#MAX_THREADS and MAX_PR_THREADS

    [ https://issues.apache.org/jira/browse/GEODE-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259162#comment-17259162 ] 

ASF GitHub Bot commented on GEODE-8799:
---------------------------------------

DonalEvans commented on a change in pull request #5862:
URL: https://github.com/apache/geode/pull/5862#discussion_r552148174



##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/OperationExecutors.java
##########
@@ -26,7 +26,7 @@
  */
 public interface OperationExecutors {
   int MAX_THREADS =
-      Integer.getInteger("DistributionManager.MAX_THREADS", 100);
+      Integer.getInteger("DistributionManager.MAX_THREADS", 300);

Review comment:
       Having talked to some other people with more hands-on experience with hitting the limit currently set by `MAX_THREADS`, a value of 1000 was decided to be more appropriate. The PR has been updated to reflect this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Increase default OperationExecutors#MAX_THREADS and MAX_PR_THREADS
> ------------------------------------------------------------------
>
>                 Key: GEODE-8799
>                 URL: https://issues.apache.org/jira/browse/GEODE-8799
>             Project: Geode
>          Issue Type: Improvement
>    Affects Versions: 1.14.0
>            Reporter: Donal Evans
>            Assignee: Donal Evans
>            Priority: Major
>              Labels: pull-request-available
>
> Similar to GEODE-8780, the default maximum number of pooled message processor and partitioned region message processor threads are low enough that they can cause performance degradation and should be increased.
> The current default value for {{MAX_THREADS}} is 100, and the current default value for {{MAX_PR_THREADS}} is 
> {{Math.max(Runtime.getRuntime().availableProcessors() * 4, 16)}}
> The proposed new values are 1000 and 
> {{Math.max(Runtime.getRuntime().availableProcessors() * 32, 200)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)