[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5417: [RUNTIME][uTVM] AutoTVM + uTVM for Cortex-M7

[GitBox <gi...@apache.org>]

tmoreau89 commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r416116610



##########
File path: python/tvm/autotvm/tuner/tuner.py
##########
@@ -150,7 +150,15 @@ def tune(self, n_trial, measure_option, early_stopping=None, callbacks=(), si_pr
                              i + k + 1, si_prefix, format_si_prefix(flops, si_prefix),
                              format_si_prefix(self.best_flops, si_prefix), res, config)
 
-            i += len(results)
+            num_successes = 0
+            for result in results:
+                if isinstance(result.costs[0], float):
+                    num_successes += 1
+            if num_successes != len(results):
+                logger.debug('not counting %d failures towards trial count',
+                             len(results) - num_successes)
+            i += num_successes
+

Review comment:
       Yeah I would be in favor of cleaning that up; it's implied that trial count includes both successful and unsuccessful runs. If we wanted to change that definition, I think we'd need an RFC to isolate that change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org