You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/03/29 07:43:56 UTC
Review Request: Logging UI fixes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4550/
-----------------------------------------------------------
Review request for mesos, Matei Zaharia and Vinod Kone.
Summary
-------
See summary.
Diffs
-----
bin/mesos-build-env.sh.in 5783fa1
src/common/logging.cpp 7a54ab1
src/webui/master/index.tpl 73cccb4
src/webui/master/webui.py 09ec8b8
src/webui/slave/index.tpl 0f18de6
src/webui/slave/webui.py 8221aca
Diff: https://reviews.apache.org/r/4550/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Logging UI fixes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-29 18:29:32, Matei Zaharia wrote:
> > Looks like you forgot to upload the updated patch. But anyway, once you have that, ship it.
Ugh, uploaded. Thanks.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4550/#review6529
-----------------------------------------------------------
On 2012-03-29 18:31:30, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4550/
> -----------------------------------------------------------
>
> (Updated 2012-03-29 18:31:30)
>
>
> Review request for mesos, Matei Zaharia and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 5783fa1
> src/common/logging.cpp 7a54ab1
> src/webui/master/index.tpl 73cccb4
> src/webui/master/webui.py 09ec8b8
> src/webui/slave/index.tpl 0f18de6
> src/webui/slave/webui.py 8221aca
>
> Diff: https://reviews.apache.org/r/4550/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Logging UI fixes.
Posted by Matei Zaharia <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4550/#review6529
-----------------------------------------------------------
Ship it!
Looks like you forgot to upload the updated patch. But anyway, once you have that, ship it.
- Matei
On 2012-03-29 18:20:31, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4550/
> -----------------------------------------------------------
>
> (Updated 2012-03-29 18:20:31)
>
>
> Review request for mesos, Matei Zaharia and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 5783fa1
> src/common/logging.cpp 7a54ab1
> src/webui/master/index.tpl 73cccb4
> src/webui/master/webui.py 09ec8b8
> src/webui/slave/index.tpl 0f18de6
> src/webui/slave/webui.py 8221aca
>
> Diff: https://reviews.apache.org/r/4550/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Logging UI fixes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4550/
-----------------------------------------------------------
(Updated 2012-03-29 18:31:30.803066)
Review request for mesos, Matei Zaharia and Vinod Kone.
Changes
-------
Updated patch (for realz this time).
Summary
-------
See summary.
Diffs (updated)
-----
bin/mesos-build-env.sh.in 5783fa1
src/common/logging.cpp 7a54ab1
src/webui/master/index.tpl 73cccb4
src/webui/master/webui.py 09ec8b8
src/webui/slave/index.tpl 0f18de6
src/webui/slave/webui.py 8221aca
Diff: https://reviews.apache.org/r/4550/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Logging UI fixes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4550/
-----------------------------------------------------------
(Updated 2012-03-29 18:20:31.521116)
Review request for mesos, Matei Zaharia and Vinod Kone.
Changes
-------
Review comments.
Summary
-------
See summary.
Diffs (updated)
-----
bin/mesos-build-env.sh.in 5783fa1
src/common/logging.cpp 7a54ab1
src/webui/master/index.tpl 73cccb4
src/webui/master/webui.py 09ec8b8
src/webui/slave/index.tpl 0f18de6
src/webui/slave/webui.py 8221aca
Diff: https://reviews.apache.org/r/4550/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Logging UI fixes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-29 15:47:22, Matei Zaharia wrote:
> > src/webui/slave/index.tpl, line 49
> > <https://reviews.apache.org/r/4550/diff/1/?file=97304#file97304line49>
> >
> > Call this just log_dir so that people using the config file know how to set it
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4550/#review6520
-----------------------------------------------------------
On 2012-03-29 18:20:31, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4550/
> -----------------------------------------------------------
>
> (Updated 2012-03-29 18:20:31)
>
>
> Review request for mesos, Matei Zaharia and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 5783fa1
> src/common/logging.cpp 7a54ab1
> src/webui/master/index.tpl 73cccb4
> src/webui/master/webui.py 09ec8b8
> src/webui/slave/index.tpl 0f18de6
> src/webui/slave/webui.py 8221aca
>
> Diff: https://reviews.apache.org/r/4550/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Logging UI fixes.
Posted by Matei Zaharia <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4550/#review6520
-----------------------------------------------------------
src/webui/slave/index.tpl
<https://reviews.apache.org/r/4550/#comment14184>
Call this just log_dir so that people using the config file know how to set it
- Matei
On 2012-03-29 05:43:56, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4550/
> -----------------------------------------------------------
>
> (Updated 2012-03-29 05:43:56)
>
>
> Review request for mesos, Matei Zaharia and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> bin/mesos-build-env.sh.in 5783fa1
> src/common/logging.cpp 7a54ab1
> src/webui/master/index.tpl 73cccb4
> src/webui/master/webui.py 09ec8b8
> src/webui/slave/index.tpl 0f18de6
> src/webui/slave/webui.py 8221aca
>
> Diff: https://reviews.apache.org/r/4550/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>