You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/02/12 04:35:58 UTC
Review Request 72117: ATLAS-3613: updated search to support namespace
attributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72117/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, keval bhatt, Mandar Ambawane, mayank jain, Nixon Rodrigues, Pinal Shah, and Sidharth Mishra.
Bugs: ATLAS-3613
https://issues.apache.org/jira/browse/ATLAS-3613
Repository: atlas
Description
-------
- updated AtlasStruct.getAttribute() to handle namespace attributes of format <namespaceName>.<attributeName>. With this change, basic-search handles namespace-attributes just as regular entity attributes are handled
- updated IdentifierHelper to handle namespace attributes of format <namespaceName>.<attributeName>, so that namespace attributes can be used in DSL searches
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 1518bbca8
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 7594153aa
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 6bd3a1181
repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 801ec029a
repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 2878a74af
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java f511e2fc3
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 113325d5d
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 55c1cacf4
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java 1d6534e3c
Diff: https://reviews.apache.org/r/72117/diff/1/
Testing
-------
- created 2 namespaces, testNamespace1 and testNamespace2, having atttributes nsAttr1 and nsAttr2 assigned to entity-types hive_table, hbase_table, hdfs_path
- verified that basic-search handles namespace attributes of format <namespaceName>.<attributeName> (like testNamespace1.nsAttr1) and returns entities having specified value
- verified that DSL-search handles namespace attributes similarly
Thanks,
Madhan Neethiraj
Re: Review Request 72117: ATLAS-3613: updated search to support
namespace attributes
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72117/#review219597
-----------------------------------------------------------
Ship it!
Can you please add examples for DSL and Basic Search with namespaces?
- Ashutosh Mestry
On Feb. 12, 2020, 4:35 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72117/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2020, 4:35 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, keval bhatt, madhan, Mandar Ambawane, mayank jain, Nixon Rodrigues, Pinal Shah, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3613
> https://issues.apache.org/jira/browse/ATLAS-3613
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated AtlasStruct.getAttribute() to handle namespace attributes of format <namespaceName>.<attributeName>. With this change, basic-search handles namespace-attributes just as regular entity attributes are handled
> - updated IdentifierHelper to handle namespace attributes of format <namespaceName>.<attributeName>, so that namespace attributes can be used in DSL searches
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 1518bbca8
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 7594153aa
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 6bd3a1181
> repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 8256d25af
> repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 801ec029a
> repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 2878a74af
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java f511e2fc3
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 113325d5d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 55c1cacf4
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java 1d6534e3c
>
>
> Diff: https://reviews.apache.org/r/72117/diff/3/
>
>
> Testing
> -------
>
> - created 2 namespaces, testNamespace1 and testNamespace2, having atttributes nsAttr1 and nsAttr2 assigned to entity-types hive_table, hbase_table, hdfs_path
> - verified that basic-search handles namespace attributes of format <namespaceName>.<attributeName> (like testNamespace1.nsAttr1) and returns entities having specified value
> - verified that DSL-search handles namespace attributes similarly
> - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1626/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>