You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/29 12:27:07 UTC

[GitHub] [ignite] tledkov commented on a diff in pull request #10200: IGNITE-15424 Move query schema management infrastructure to the core module

tledkov commented on code in PR #10200:
URL: https://github.com/apache/ignite/pull/10200#discussion_r957262217


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ddl/DdlCommandHandler.java:
##########
@@ -195,20 +196,22 @@ private void handle0(DropTableCommand cmd) throws IgniteCheckedException {
 
         security.authorize(cacheName, SecurityPermission.CACHE_DESTROY);
 
-        qryProcessorSupp.get().dynamicTableDrop(cacheName, cmd.tableName(), cmd.ifExists());
+        qryProc.dynamicTableDrop(cacheName, cmd.tableName(), cmd.ifExists());
     }
 
     /** */
     private void handle0(AlterTableAddCommand cmd) throws IgniteCheckedException {
         isDdlOnSchemaSupported(cmd.schemaName());
 
-        GridQueryTypeDescriptor typeDesc = schemaMgr.typeDescriptorForTable(cmd.schemaName(), cmd.tableName());
+        TableDescriptor tblDesc = schemaMgr.table(cmd.schemaName(), cmd.tableName());
 
-        if (typeDesc == null) {
+        if (tblDesc == null) {
             if (!cmd.ifTableExists())
                 throw new SchemaOperationException(SchemaOperationException.CODE_TABLE_NOT_FOUND, cmd.tableName());
         }
         else {
+            GridQueryTypeDescriptor typeDesc = tblDesc.type();

Review Comment:
   May be drop 'Grid' prefix for `GridQueryTypeDescriptor` too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org