You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/11/27 16:16:53 UTC
Review Request 40772: LENS-888: Limit of 4000 on total string length
of dim attribute names of derived cube
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-888
https://issues.apache.org/jira/browse/LENS-888
Repository: lens
Description
-------
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
Diff: https://reviews.apache.org/r/40772/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40772: LENS-888: Limit of 4000 on total string
length of dim attribute names of derived cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 30, 2015, 2:34 p.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java, line 175
> > <https://reviews.apache.org/r/40772/diff/2/?file=1148162#file1148162line175>
> >
> > What happens if a single name > Max allowed lenght. Does the code need to handle that as well?
Not needed I think. Using hive metastore is a design decision. If such cases start appearing then we need to seriously question that decision. I don't expect such cases anytime soon. So Let's not worry about that case :)
> On Nov. 30, 2015, 2:34 p.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java, line 146
> > <https://reviews.apache.org/r/40772/diff/2/?file=1148162#file1148162line146>
> >
> > Shall we call it updateDimProperties()?
Renamed.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/#review108300
-----------------------------------------------------------
On Nov. 30, 2015, 2:25 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40772/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 2:25 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-888
> https://issues.apache.org/jira/browse/LENS-888
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
>
> Diff: https://reviews.apache.org/r/40772/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.837s]
> [INFO] Lens .............................................. SUCCESS [3.131s]
> [INFO] Lens API .......................................... SUCCESS [22.055s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.351s]
> [INFO] Lens Cube ......................................... SUCCESS [11:40.644s]
> [INFO] Lens DB storage ................................... SUCCESS [20.933s]
> [INFO] Lens Query Library ................................ SUCCESS [16.187s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:47.504s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.105s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.141s]
> [INFO] Lens Server ....................................... SUCCESS [9:51.545s]
> [INFO] Lens client ....................................... SUCCESS [34.184s]
> [INFO] Lens CLI .......................................... SUCCESS [51.470s]
> [INFO] Lens Examples ..................................... SUCCESS [8.469s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.695s]
> [INFO] Lens Distribution ................................. SUCCESS [8.603s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.635s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.852s]
> [INFO] Lens Regression ................................... SUCCESS [14.152s]
> [INFO] Lens UI ........................................... SUCCESS [27.439s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:24.882s
> [INFO] Finished at: Mon Nov 30 08:42:30 UTC 2015
> [INFO] Final Memory: 181M/1229M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40772: LENS-888: Limit of 4000 on total string
length of dim attribute names of derived cube
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/#review108300
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java (line 145)
<https://reviews.apache.org/r/40772/#comment167699>
Shall we call it updateDimProperties()?
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java (line 174)
<https://reviews.apache.org/r/40772/#comment167700>
What happens if a single name > Max allowed lenght. Does the code need to handle that as well?
- Puneet Gupta
On Nov. 30, 2015, 8:55 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40772/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 8:55 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-888
> https://issues.apache.org/jira/browse/LENS-888
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
>
> Diff: https://reviews.apache.org/r/40772/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.837s]
> [INFO] Lens .............................................. SUCCESS [3.131s]
> [INFO] Lens API .......................................... SUCCESS [22.055s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.351s]
> [INFO] Lens Cube ......................................... SUCCESS [11:40.644s]
> [INFO] Lens DB storage ................................... SUCCESS [20.933s]
> [INFO] Lens Query Library ................................ SUCCESS [16.187s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:47.504s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.105s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.141s]
> [INFO] Lens Server ....................................... SUCCESS [9:51.545s]
> [INFO] Lens client ....................................... SUCCESS [34.184s]
> [INFO] Lens CLI .......................................... SUCCESS [51.470s]
> [INFO] Lens Examples ..................................... SUCCESS [8.469s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.695s]
> [INFO] Lens Distribution ................................. SUCCESS [8.603s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.635s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.852s]
> [INFO] Lens Regression ................................... SUCCESS [14.152s]
> [INFO] Lens UI ........................................... SUCCESS [27.439s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:24.882s
> [INFO] Finished at: Mon Nov 30 08:42:30 UTC 2015
> [INFO] Final Memory: 181M/1229M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40772: LENS-888: Limit of 4000 on total string
length of dim attribute names of derived cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/#review108301
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Nov. 30, 2015, 8:55 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40772/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 8:55 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-888
> https://issues.apache.org/jira/browse/LENS-888
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
>
> Diff: https://reviews.apache.org/r/40772/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.837s]
> [INFO] Lens .............................................. SUCCESS [3.131s]
> [INFO] Lens API .......................................... SUCCESS [22.055s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.351s]
> [INFO] Lens Cube ......................................... SUCCESS [11:40.644s]
> [INFO] Lens DB storage ................................... SUCCESS [20.933s]
> [INFO] Lens Query Library ................................ SUCCESS [16.187s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:47.504s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.105s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.141s]
> [INFO] Lens Server ....................................... SUCCESS [9:51.545s]
> [INFO] Lens client ....................................... SUCCESS [34.184s]
> [INFO] Lens CLI .......................................... SUCCESS [51.470s]
> [INFO] Lens Examples ..................................... SUCCESS [8.469s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.695s]
> [INFO] Lens Distribution ................................. SUCCESS [8.603s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.635s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.852s]
> [INFO] Lens Regression ................................... SUCCESS [14.152s]
> [INFO] Lens UI ........................................... SUCCESS [27.439s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:24.882s
> [INFO] Finished at: Mon Nov 30 08:42:30 UTC 2015
> [INFO] Final Memory: 181M/1229M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 40772: LENS-888: Limit of 4000 on total string
length of dim attribute names of derived cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 2:49 p.m.)
Review request for lens.
Bugs: LENS-888
https://issues.apache.org/jira/browse/LENS-888
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
Diff: https://reviews.apache.org/r/40772/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.837s]
[INFO] Lens .............................................. SUCCESS [3.131s]
[INFO] Lens API .......................................... SUCCESS [22.055s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.351s]
[INFO] Lens Cube ......................................... SUCCESS [11:40.644s]
[INFO] Lens DB storage ................................... SUCCESS [20.933s]
[INFO] Lens Query Library ................................ SUCCESS [16.187s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.504s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.105s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.141s]
[INFO] Lens Server ....................................... SUCCESS [9:51.545s]
[INFO] Lens client ....................................... SUCCESS [34.184s]
[INFO] Lens CLI .......................................... SUCCESS [51.470s]
[INFO] Lens Examples ..................................... SUCCESS [8.469s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.695s]
[INFO] Lens Distribution ................................. SUCCESS [8.603s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.635s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.852s]
[INFO] Lens Regression ................................... SUCCESS [14.152s]
[INFO] Lens UI ........................................... SUCCESS [27.439s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:24.882s
[INFO] Finished at: Mon Nov 30 08:42:30 UTC 2015
[INFO] Final Memory: 181M/1229M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40772: LENS-888: Limit of 4000 on total string
length of dim attribute names of derived cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 2:25 p.m.)
Review request for lens.
Bugs: LENS-888
https://issues.apache.org/jira/browse/LENS-888
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
Diff: https://reviews.apache.org/r/40772/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.837s]
[INFO] Lens .............................................. SUCCESS [3.131s]
[INFO] Lens API .......................................... SUCCESS [22.055s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.351s]
[INFO] Lens Cube ......................................... SUCCESS [11:40.644s]
[INFO] Lens DB storage ................................... SUCCESS [20.933s]
[INFO] Lens Query Library ................................ SUCCESS [16.187s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.504s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.105s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.141s]
[INFO] Lens Server ....................................... SUCCESS [9:51.545s]
[INFO] Lens client ....................................... SUCCESS [34.184s]
[INFO] Lens CLI .......................................... SUCCESS [51.470s]
[INFO] Lens Examples ..................................... SUCCESS [8.469s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.695s]
[INFO] Lens Distribution ................................. SUCCESS [8.603s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.635s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.852s]
[INFO] Lens Regression ................................... SUCCESS [14.152s]
[INFO] Lens UI ........................................... SUCCESS [27.439s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:24.882s
[INFO] Finished at: Mon Nov 30 08:42:30 UTC 2015
[INFO] Final Memory: 181M/1229M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 40772: LENS-888: Limit of 4000 on total string
length of dim attribute names of derived cube
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 1:05 p.m.)
Review request for lens.
Bugs: LENS-888
https://issues.apache.org/jira/browse/LENS-888
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb
Diff: https://reviews.apache.org/r/40772/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40772: LENS-888: Limit of 4000 on total string
length of dim attribute names of derived cube
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40772/#review108282
-----------------------------------------------------------
Can you update the testing done?
- Amareshwari Sriramadasu
On Nov. 27, 2015, 3:16 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40772/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 3:16 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-888
> https://issues.apache.org/jira/browse/LENS-888
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 3c30f78516c8c5fd9ca45aa58d4187758c66d0bf
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 4b57d95180a700fa65b213e1c7a2a036ec509579
>
> Diff: https://reviews.apache.org/r/40772/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>