You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2017/02/24 05:20:03 UTC

[GitHub] spark pull request #17049: [SPARK-17495] [SQL] Add more tests for hive hash

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17049#discussion_r102881054
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala ---
    @@ -71,6 +75,242 @@ class HashExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
         checkConsistencyBetweenInterpretedAndCodegen(Crc32, BinaryType)
       }
     
    +
    +  def checkHiveHash(value: Any, dataType: DataType, expected: Long): Unit = {
    +    // Note : All expected hashes need to be computed using Hive 1.2.1
    +    val actual = HiveHashFunction.hash(value, dataType, seed = 0)
    +    assert(actual == expected)
    --- End diff --
    
    we should add a clue; otherwise we will never be able to tell what's going on if the tests fail on those randomized vlaues.
    
    ```
    withClue(s"value is $value") {
      assert(..
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org