You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/09 23:25:29 UTC
[GitHub] [incubator-pekko-connectors-kafka] pjfanning opened a new pull request, #35: use correct config names and replace Akka/Alpakka mentions
pjfanning opened a new pull request, #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35
* also get rid of release notes (Lightbend specific)
* remove link to Lightbend Telemetry product
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103618875
##########
docs/src/main/paradox/producer.md:
##########
@@ -150,7 +150,7 @@ For flows the @apidoc[ProducerMessage.PassThroughMessage]s continue as @apidoc[P
## Producer as a Flow
-@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.javadsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.scaladsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
+@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.javadsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.scaladsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
Review Comment:
Typo: I think this replacement is done in multiple places
`org.apache.pekko` instead of `orh.apache.pekko`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103627404
##########
docs/src/main/paradox/cluster-sharding.md:
##########
@@ -14,23 +14,23 @@ When partitions and shards are co-located together then there is less chance tha
## Dependency
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-cluster-sharding_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-cluster-sharding_$scala.binary.version$
Review Comment:
New name of the artifact is `pekko-connectors-kafka-cluster-sharding`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103618875
##########
docs/src/main/paradox/producer.md:
##########
@@ -150,7 +150,7 @@ For flows the @apidoc[ProducerMessage.PassThroughMessage]s continue as @apidoc[P
## Producer as a Flow
-@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.javadsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.scaladsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
+@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.javadsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.scaladsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
Review Comment:
```suggestion
orh.apache.pekko
org.apache.pekko
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103619992
##########
docs/src/main/paradox/snapshots.md:
##########
@@ -1,13 +1,13 @@
---
-project.description: Snapshot builds of Alpakka Kafka are provided via the Sonatype snapshot repository.
+project.description: Snapshot builds of Apache Pekko Connectors Kafka are provided via the Sonatype snapshot repository.
---
# Snapshots
-[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/akka-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
-[snapshots]: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/akka-stream-kafka_2.13/
+[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/pekko-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
+[snapshots]: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/pekko-stream-kafka_2.13/
Review Comment:
Is it correct one?
`https://repository.apache.org/content/groups/snapshots/org/apache/pekko/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103619592
##########
docs/src/main/paradox/snapshots.md:
##########
@@ -1,13 +1,13 @@
---
-project.description: Snapshot builds of Alpakka Kafka are provided via the Sonatype snapshot repository.
+project.description: Snapshot builds of Apache Pekko Connectors Kafka are provided via the Sonatype snapshot repository.
---
# Snapshots
-[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/akka-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
-[snapshots]: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/akka-stream-kafka_2.13/
+[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/pekko-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
Review Comment:
This badge still pointing to `typesafe`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103630295
##########
docs/src/main/paradox/debugging.md:
##########
@@ -1,31 +1,31 @@
# Debugging
-Debugging setups with the Alpakka Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
+Debugging setups with the Apache Pekko Connectors Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
## Logging with SLF4J
-Akka, Akka Streams and thus the Alpakka Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Akka's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
+Apache Pekko, Apache Pekko Streams and thus the Apache Pekko Connectors Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Apache Pekko's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
-The Kafka client library used by the Alpakka Kafka connector uses SLF4J, as well.
+The Kafka client library used by the Apache Pekko Connectors Kafka connector uses SLF4J, as well.
@@dependency [Maven,sbt,Gradle] {
- symbol=AkkaVersion
- value="$akka.version$"
- group=com.typesafe.akka
+ symbol=PekkoVersion
+ value="$pekko.version$"
+ group=org.apache.pekko
artifact=akka-slf4j_$scala.binary.version$
- version=AkkaVersion
+ version=PekkoVersion
group2=ch.qos.logback
artifact2=logback-classic
version2=1.2.3
}
-To enable Akka SLF4J logging, configure Akka in `application.conf` as below. Refer to the @extref[Pekko documentation](pekko:logging.html#slf4j) for details.
+To enable Apache Pekko SLF4J logging, configure Apache Pekko in `application.conf` as below. Refer to the @extref[Pekko documentation](pekko:logging.html#slf4j) for details.
```hocon
akka {
Review Comment:
`pekko {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#issuecomment-1426850846
I think issue#20 issue#29 can be closed isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#issuecomment-1426843289
IMHO: following files can be deleted, I don't see the usage of `logo.st`
```
./docs/src/main/paradox/_template/logo.st
./docs/src/main/paradox/images/akka-alpakka-reverse.svg
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103618875
##########
docs/src/main/paradox/producer.md:
##########
@@ -150,7 +150,7 @@ For flows the @apidoc[ProducerMessage.PassThroughMessage]s continue as @apidoc[P
## Producer as a Flow
-@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.javadsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.scaladsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
+@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.javadsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.scaladsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
Review Comment:
Typo:
```suggestion
orh.apache.pekko
org.apache.pekko
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103677860
##########
docs/release-train-issue-template.md:
##########
@@ -42,7 +42,7 @@ Key links:
### Check availability
- [ ] Check [API](https://doc.akka.io/api/alpakka-kafka/$VERSION$/) documentation
-- [ ] Check [reference](https://doc.akka.io/docs/alpakka-kafka/$VERSION$/) documentation
Review Comment:
raised #40 for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103624355
##########
docs/src/main/paradox/testing.md:
##########
@@ -39,18 +39,18 @@ See the documentation for each for more details.
| Type | Test Framework | Cluster | Lang | Lifetime |
|---------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|-------------|--------------|--------------------------|
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaTest`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 5 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | All tests |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaPerClassLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | Per class |
+| @ref:[`pekko.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
+| @ref:[`pekko.kafka.testkit.javadsl.TestcontainersKafkaTest`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 5 | Yes | Java | All tests, Per class |
+| @ref:[`pekko.kafka.testkit.scaladsl.TestcontainersKafkaLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | All tests |
+| @ref:[`pekko.kafka.testkit.scaladsl.TestcontainersKafkaPerClassLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | Per class |
## Alternative testing libraries
If using Maven and Java, an alternative library that provides running Kafka broker instance during testing is [kafka-unit by salesforce](https://github.com/salesforce/kafka-junit). It has support for Junit 4 and 5 and supports many different versions of Kafka.
## Mocking the Consumer or Producer
-The testkit contains factories to create the messages emitted by Consumer sources in `akka.kafka.testkit.ConsumerResultFactory` and Producer flows in `akka.kafka.testkit.ProducerResultFactory`.
+The testkit contains factories to create the messages emitted by Consumer sources in `pekko.kafka.testkit.ConsumerResultFactory` and Producer flows in `pekko.kafka.testkit.ProducerResultFactory`.
Review Comment:
thanks - fixing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103630801
##########
docs/src/main/paradox/producer.md:
##########
@@ -150,7 +150,7 @@ For flows the @apidoc[ProducerMessage.PassThroughMessage]s continue as @apidoc[P
## Producer as a Flow
-@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.javadsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.scaladsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
+@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.javadsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.scaladsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
Review Comment:
thanks - fixed the typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103620518
##########
docs/src/main/paradox/testing.md:
##########
@@ -1,31 +1,31 @@
---
-project.description: Alpakka Kafka provides a Testkit with support for running local Kafka brokers for integration tests.
+project.description: Apache Pekko Connectors Kafka provides a Testkit with support for running local Kafka brokers for integration tests.
---
# Testing
-To simplify testing of streaming integrations with Alpakka Kafka, it provides the **Alpakka Kafka testkit**. It provides help for
+To simplify testing of streaming integrations with Apache Pekko Connectors Kafka, it provides the **Apache Pekko Connectors Kafka testkit**. It provides help for
* @ref:[Using Docker to launch a local Kafka cluster with testcontainers](testing-testcontainers.md)
-* @ref:[Mocking the Alpakka Kafka Consumers and Producers](#mocking-the-consumer-or-producer)
+* @ref:[Mocking the Apache Pekko Connectors Kafka Consumers and Producers](#mocking-the-consumer-or-producer)
@@project-info{ projectId="testkit" }
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-testkit_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-testkit_$scala.binary.version$
version=$project.version$
scope=test
- symbol2=AkkaVersion
+ symbol2=PekkoVersion
value2="$akka.version$"
Review Comment:
`$pekko.version$`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103628193
##########
docs/src/main/paradox/cluster-sharding.md:
##########
@@ -14,23 +14,23 @@ When partitions and shards are co-located together then there is less chance tha
## Dependency
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-cluster-sharding_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-cluster-sharding_$scala.binary.version$
version=$project.version$
- symbol2=AkkaVersion
+ symbol2=PekkoVersion
value2="$akka.version$"
- group2=com.typesafe.akka
- artifact2=akka-cluster-sharding-typed_$scala.binary.version$
- version2=AkkaVersion
+ group2=org.apache.pekko
+ artifact2=pekko-cluster-sharding-typed_$scala.binary.version$
Review Comment:
I don't see `scala.binary.version` configured in `ParadoxSettings`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103632800
##########
docs/src/main/paradox/snapshots.md:
##########
@@ -1,13 +1,13 @@
---
-project.description: Snapshot builds of Alpakka Kafka are provided via the Sonatype snapshot repository.
+project.description: Snapshot builds of Apache Pekko Connectors Kafka are provided via the Sonatype snapshot repository.
---
# Snapshots
-[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/akka-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
-[snapshots]: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/akka-stream-kafka_2.13/
+[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/pekko-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
+[snapshots]: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/pekko-stream-kafka_2.13/
Review Comment:
updated - snapshots docs are low priority - ultimately, we might need to remove them - ASF discourages use of snapshots and we're not meant to advertise them too much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103634293
##########
docs/src/main/paradox/cluster-sharding.md:
##########
@@ -14,23 +14,23 @@ When partitions and shards are co-located together then there is less chance tha
## Dependency
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-cluster-sharding_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-cluster-sharding_$scala.binary.version$
version=$project.version$
- symbol2=AkkaVersion
+ symbol2=PekkoVersion
value2="$akka.version$"
- group2=com.typesafe.akka
- artifact2=akka-cluster-sharding-typed_$scala.binary.version$
- version2=AkkaVersion
+ group2=org.apache.pekko
+ artifact2=pekko-cluster-sharding-typed_$scala.binary.version$
Review Comment:
I think this is derived based on the scala version used to build the application (it appears as 2.13 on my laptop)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103620164
##########
docs/src/main/paradox/snapshots.md:
##########
@@ -48,4 +48,4 @@ The [snapshot documentation](https://doc.akka.io/docs/alpakka-kafka/snapshot/) i
Latest published snapshot version is [![snapshots-badge][]][snapshots]
-The snapshot repository is cleaned from time to time with no further notice. Check [Sonatype snapshots Alpakka Kafka files](https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/akka-stream-kafka_2.13/) to see what versions are currently available.
+The snapshot repository is cleaned from time to time with no further notice. Check [Sonatype snapshots Apache Pekko Connectors Kafka files](https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/pekko-stream-kafka_2.13/) to see what versions are currently available.
Review Comment:
Same.... link needs to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103628883
##########
docs/src/main/paradox/home.md:
##########
@@ -41,50 +29,50 @@ Check even Confluent's [Versions and Interoperability](https://docs.confluent.io
## Dependencies
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka_$scala.binary.version$
Review Comment:
new artifact name is `pekko-connectors-kafka`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103618875
##########
docs/src/main/paradox/producer.md:
##########
@@ -150,7 +150,7 @@ For flows the @apidoc[ProducerMessage.PassThroughMessage]s continue as @apidoc[P
## Producer as a Flow
-@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.javadsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:akka.kafka.ProducerSettings[K,V]):akka.stream.scaladsl.Flow[akka.kafka.ProducerMessage.Envelope[K,V,PassThrough],akka.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
+@apidoc[Producer.flexiFlow](Producer$) { java="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.javadsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" scala="#flexiFlow[K,V,PassThrough](settings:pekko.kafka.ProducerSettings[K,V]):orh.apache.pekko.stream.scaladsl.Flow[pekko.kafka.ProducerMessage.Envelope[K,V,PassThrough],pekko.kafka.ProducerMessage.Results[K,V,PassThrough],akka.NotUsed]" }
Review Comment:
Typo: I think this replacement is done in multiple places
```suggestion
orh.apache.pekko
org.apache.pekko
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103632881
##########
docs/src/main/paradox/snapshots.md:
##########
@@ -48,4 +48,4 @@ The [snapshot documentation](https://doc.akka.io/docs/alpakka-kafka/snapshot/) i
Latest published snapshot version is [![snapshots-badge][]][snapshots]
-The snapshot repository is cleaned from time to time with no further notice. Check [Sonatype snapshots Alpakka Kafka files](https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/akka-stream-kafka_2.13/) to see what versions are currently available.
+The snapshot repository is cleaned from time to time with no further notice. Check [Sonatype snapshots Apache Pekko Connectors Kafka files](https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/pekko-stream-kafka_2.13/) to see what versions are currently available.
Review Comment:
page updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103621041
##########
docs/src/main/paradox/testing.md:
##########
@@ -39,18 +39,18 @@ See the documentation for each for more details.
| Type | Test Framework | Cluster | Lang | Lifetime |
|---------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|-------------|--------------|--------------------------|
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaTest`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 5 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | All tests |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaPerClassLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | Per class |
+| @ref:[`pekko.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
+| @ref:[`pekko.kafka.testkit.javadsl.TestcontainersKafkaTest`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 5 | Yes | Java | All tests, Per class |
+| @ref:[`pekko.kafka.testkit.scaladsl.TestcontainersKafkaLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | All tests |
+| @ref:[`pekko.kafka.testkit.scaladsl.TestcontainersKafkaPerClassLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | Per class |
## Alternative testing libraries
If using Maven and Java, an alternative library that provides running Kafka broker instance during testing is [kafka-unit by salesforce](https://github.com/salesforce/kafka-junit). It has support for Junit 4 and 5 and supports many different versions of Kafka.
## Mocking the Consumer or Producer
-The testkit contains factories to create the messages emitted by Consumer sources in `akka.kafka.testkit.ConsumerResultFactory` and Producer flows in `akka.kafka.testkit.ProducerResultFactory`.
+The testkit contains factories to create the messages emitted by Consumer sources in `pekko.kafka.testkit.ConsumerResultFactory` and Producer flows in `pekko.kafka.testkit.ProducerResultFactory`.
Review Comment:
here too `org.apache.pekko`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103634368
##########
docs/src/main/paradox/snapshots.md:
##########
@@ -1,13 +1,13 @@
---
-project.description: Snapshot builds of Alpakka Kafka are provided via the Sonatype snapshot repository.
+project.description: Snapshot builds of Apache Pekko Connectors Kafka are provided via the Sonatype snapshot repository.
---
# Snapshots
-[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/akka-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
-[snapshots]: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/akka/akka-stream-kafka_2.13/
+[snapshots-badge]: https://img.shields.io/nexus/s/com.typesafe.akka/pekko-stream-kafka_2.13?server=https%3A%2F%2Foss.sonatype.org
Review Comment:
removing this badge because the badge probably only works for sonatype snapshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103673371
##########
docs/release-train-issue-template.md:
##########
@@ -42,7 +42,7 @@ Key links:
### Check availability
- [ ] Check [API](https://doc.akka.io/api/alpakka-kafka/$VERSION$/) documentation
-- [ ] Check [reference](https://doc.akka.io/docs/alpakka-kafka/$VERSION$/) documentation
Review Comment:
This page has references to alpakka but this needs to be adjusted in future when we do first release (I guess). Do we need any issue to be created for tracking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#issuecomment-1426851990
> I think issue#20 issue#29 can be closed isn't it?
I'm afraid I can't merge this until a PMC member reviews this too. Thanks very much for your patient reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#issuecomment-1426849920
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103674850
##########
docs/src/main/paradox/consumer.md:
##########
@@ -96,9 +96,9 @@ Java
The Kafka read offset can either be stored in Kafka (see below), or at a data store of your choice.
-@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.scaladsl.Consumer.Control]" }
+@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.scaladsl.Consumer.Control]" }
Review Comment:
in multiple places
```
org.apache.pekko.kafka.Subscription
org.apache.pekko.kafka.AutoSubscription
org.apache.pekko.kafka.scaladsl.Consumer.Control
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103674850
##########
docs/src/main/paradox/consumer.md:
##########
@@ -96,9 +96,9 @@ Java
The Kafka read offset can either be stored in Kafka (see below), or at a data store of your choice.
-@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.scaladsl.Consumer.Control]" }
+@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.scaladsl.Consumer.Control]" }
Review Comment:
in multiple places
```
org.apache.pekko.kafka.Subscription
org.apache.pekko.kafka.scaladsl.Consumer.Control
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103674850
##########
docs/src/main/paradox/consumer.md:
##########
@@ -96,9 +96,9 @@ Java
The Kafka read offset can either be stored in Kafka (see below), or at a data store of your choice.
-@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.scaladsl.Consumer.Control]" }
+@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.scaladsl.Consumer.Control]" }
Review Comment:
```
org.apache.pekko.kafka.Subscription
org.apache.pekko.kafka.scaladsl.Consumer.Control
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103679049
##########
docs/src/main/paradox/consumer.md:
##########
@@ -96,9 +96,9 @@ Java
The Kafka read offset can either be stored in Kafka (see below), or at a data store of your choice.
-@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.scaladsl.Consumer.Control]" }
+@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.scaladsl.Consumer.Control]" }
Review Comment:
think this is fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103628754
##########
docs/src/main/paradox/discovery.md:
##########
@@ -1,35 +1,35 @@
---
-project.description: Akka Discovery can be used to achieve Kafka broker discovery from the operations environment.
+project.description: Apache Pekko Discovery can be used to achieve Kafka broker discovery from the operations environment.
---
# Service discovery
-By using @extref:[Pekko Discovery](pekko:discovery/index.html) Alpakka Kafka may read the Kafka bootstrap server addresses from any Akka Discovery-compatible service discovery mechanism.
+By using @extref:[Pekko Discovery](pekko:discovery/index.html) Apache Pekko Connectors Kafka may read the Kafka bootstrap server addresses from any Apache Pekko Discovery-compatible service discovery mechanism.
-Akka Discovery supports Configuration (HOCON), DNS (SRV records), and aggregation of multiple discovery methods out-of-the-box. Kubernetes API, AWS API: EC2 Tag-Based Discovery, AWS API: ECS Discovery and Consul implementations for Akka Discovery are available in @extref:[Pekko Management](pekko-management:).
+Apache Pekko Discovery supports Configuration (HOCON), DNS (SRV records), and aggregation of multiple discovery methods out-of-the-box. Kubernetes API, AWS API: EC2 Tag-Based Discovery, AWS API: ECS Discovery and Consul implementations for Apache Pekko Discovery are available in @extref:[Pekko Management](pekko-management:).
## Dependency
-The Akka Discovery version must match the Akka version used in your build. To use the implementations provided by Akka Management, you need to add the desired dependency.
+The Apache Pekko Discovery version must match the Apache Pekko version used in your build. To use the implementations provided by Apache Pekko Management, you need to add the desired dependency.
@@dependency [Maven,sbt,Gradle] {
- symbol=AkkaVersion
+ symbol=PekkoVersion
value=$akka.version$
- group=com.typesafe.akka
+ group=org.apache.pekko
artifact=akka-discovery_$scala.binary.version$
Review Comment:
`pekko-discovery_`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103620921
##########
docs/src/main/paradox/testing.md:
##########
@@ -39,18 +39,18 @@ See the documentation for each for more details.
| Type | Test Framework | Cluster | Lang | Lifetime |
|---------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|-------------|--------------|--------------------------|
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaTest`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 5 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | All tests |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaPerClassLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | Per class |
+| @ref:[`pekko.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
Review Comment:
Is it `org.apache.pekko.`? if in all 4 referecnes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103673444
##########
docs/src/main/paradox/cluster-sharding.md:
##########
@@ -14,23 +14,23 @@ When partitions and shards are co-located together then there is less chance tha
## Dependency
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-cluster-sharding_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-cluster-sharding_$scala.binary.version$
version=$project.version$
- symbol2=AkkaVersion
+ symbol2=PekkoVersion
value2="$akka.version$"
- group2=com.typesafe.akka
- artifact2=akka-cluster-sharding-typed_$scala.binary.version$
- version2=AkkaVersion
+ group2=org.apache.pekko
+ artifact2=pekko-cluster-sharding-typed_$scala.binary.version$
Review Comment:
It is working for me too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103673444
##########
docs/src/main/paradox/cluster-sharding.md:
##########
@@ -14,23 +14,23 @@ When partitions and shards are co-located together then there is less chance tha
## Dependency
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-cluster-sharding_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-cluster-sharding_$scala.binary.version$
version=$project.version$
- symbol2=AkkaVersion
+ symbol2=PekkoVersion
value2="$akka.version$"
- group2=com.typesafe.akka
- artifact2=akka-cluster-sharding-typed_$scala.binary.version$
- version2=AkkaVersion
+ group2=org.apache.pekko
+ artifact2=pekko-cluster-sharding-typed_$scala.binary.version$
Review Comment:
It is working for me to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103628405
##########
docs/src/main/paradox/testing.md:
##########
@@ -1,31 +1,31 @@
---
-project.description: Alpakka Kafka provides a Testkit with support for running local Kafka brokers for integration tests.
+project.description: Apache Pekko Connectors Kafka provides a Testkit with support for running local Kafka brokers for integration tests.
---
# Testing
-To simplify testing of streaming integrations with Alpakka Kafka, it provides the **Alpakka Kafka testkit**. It provides help for
+To simplify testing of streaming integrations with Apache Pekko Connectors Kafka, it provides the **Apache Pekko Connectors Kafka testkit**. It provides help for
* @ref:[Using Docker to launch a local Kafka cluster with testcontainers](testing-testcontainers.md)
-* @ref:[Mocking the Alpakka Kafka Consumers and Producers](#mocking-the-consumer-or-producer)
+* @ref:[Mocking the Apache Pekko Connectors Kafka Consumers and Producers](#mocking-the-consumer-or-producer)
@@project-info{ projectId="testkit" }
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-testkit_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-testkit_$scala.binary.version$
Review Comment:
new artifact name is `pekko-connectors-kafka-testkit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103624292
##########
docs/src/main/paradox/testing.md:
##########
@@ -39,18 +39,18 @@ See the documentation for each for more details.
| Type | Test Framework | Cluster | Lang | Lifetime |
|---------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|-------------|--------------|--------------------------|
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaTest`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 5 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | All tests |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaPerClassLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | Per class |
+| @ref:[`pekko.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
Review Comment:
fixing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#issuecomment-1426764373
`project/project-info.conf` needs to adjusted as well, this file is used in the multiple places of the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103634232
##########
docs/src/main/paradox/debugging.md:
##########
@@ -1,31 +1,31 @@
# Debugging
-Debugging setups with the Alpakka Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
+Debugging setups with the Apache Pekko Connectors Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
## Logging with SLF4J
-Akka, Akka Streams and thus the Alpakka Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Akka's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
+Apache Pekko, Apache Pekko Streams and thus the Apache Pekko Connectors Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Apache Pekko's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
-The Kafka client library used by the Alpakka Kafka connector uses SLF4J, as well.
+The Kafka client library used by the Apache Pekko Connectors Kafka connector uses SLF4J, as well.
@@dependency [Maven,sbt,Gradle] {
- symbol=AkkaVersion
- value="$akka.version$"
- group=com.typesafe.akka
+ symbol=PekkoVersion
+ value="$pekko.version$"
+ group=org.apache.pekko
artifact=akka-slf4j_$scala.binary.version$
- version=AkkaVersion
+ version=PekkoVersion
group2=ch.qos.logback
artifact2=logback-classic
version2=1.2.3
}
-To enable Akka SLF4J logging, configure Akka in `application.conf` as below. Refer to the @extref[Pekko documentation](pekko:logging.html#slf4j) for details.
+To enable Apache Pekko SLF4J logging, configure Apache Pekko in `application.conf` as below. Refer to the @extref[Pekko documentation](pekko:logging.html#slf4j) for details.
```hocon
akka {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103633184
##########
docs/src/main/paradox/debugging.md:
##########
@@ -1,25 +1,25 @@
# Debugging
-Debugging setups with the Alpakka Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
+Debugging setups with the Apache Pekko Connectors Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
## Logging with SLF4J
-Akka, Akka Streams and thus the Alpakka Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Akka's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
+Apache Pekko, Apache Pekko Streams and thus the Apache Pekko Connectors Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Apache Pekko's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
-The Kafka client library used by the Alpakka Kafka connector uses SLF4J, as well.
+The Kafka client library used by the Apache Pekko Connectors Kafka connector uses SLF4J, as well.
@@dependency [Maven,sbt,Gradle] {
- symbol=AkkaVersion
+ symbol=PekkoVersion
value="$akka.version$"
- group=com.typesafe.akka
+ group=org.apache.pekko
artifact=akka-slf4j_$scala.binary.version$
Review Comment:
fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103620921
##########
docs/src/main/paradox/testing.md:
##########
@@ -39,18 +39,18 @@ See the documentation for each for more details.
| Type | Test Framework | Cluster | Lang | Lifetime |
|---------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------|-------------|--------------|--------------------------|
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.javadsl.TestcontainersKafkaTest`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 5 | Yes | Java | All tests, Per class |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | All tests |
-| @ref:[`akka.kafka.testkit.scaladsl.TestcontainersKafkaPerClassLike`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-scala-code) | ScalaTest | Yes | Scala | Per class |
+| @ref:[`pekko.kafka.testkit.javadsl.TestcontainersKafkaJunit4Test`](testing-testcontainers.md#testing-with-a-docker-kafka-cluster-from-java-code) | JUnit 4 | Yes | Java | All tests, Per class |
Review Comment:
In all 4 references
`org.apache.pekko.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103674850
##########
docs/src/main/paradox/consumer.md:
##########
@@ -96,9 +96,9 @@ Java
The Kafka read offset can either be stored in Kafka (see below), or at a data store of your choice.
-@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:akka.kafka.ConsumerSettings[K,V],subscription:akka.kafka.Subscription):akka.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],akka.kafka.scaladsl.Consumer.Control]" }
+@apidoc[Consumer.plainSource](Consumer$) { java="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.javadsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.javadsl.Consumer.Control]" scala="#plainSource[K,V](settings:org.apache.pekko.kafka.ConsumerSettings[K,V],subscription:pekko.kafka.Subscription):org.apache.pekko.stream.scaladsl.Source[org.apache.kafka.clients.consumer.ConsumerRecord[K,V],pekko.kafka.scaladsl.Consumer.Control]" }
Review Comment:
```
org.apache.pekko.kafka.Subscription
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#issuecomment-1428765235
Thanks @nvollmar and @Seetaramayya for reviewing this large PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning merged pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103628688
##########
docs/src/main/paradox/debugging.md:
##########
@@ -1,25 +1,25 @@
# Debugging
-Debugging setups with the Alpakka Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
+Debugging setups with the Apache Pekko Connectors Kafka Connector will be required at times. This page collects a few ideas to start out with in case the connector does not behave as you expected.
## Logging with SLF4J
-Akka, Akka Streams and thus the Alpakka Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Akka's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
+Apache Pekko, Apache Pekko Streams and thus the Apache Pekko Connectors Kafka Connector support [SLF4J logging API](https://www.slf4j.org/) by adding Apache Pekko's SLF4J module and an SLF4J compatible logging framework, eg. [Logback](https://logback.qos.ch/).
-The Kafka client library used by the Alpakka Kafka connector uses SLF4J, as well.
+The Kafka client library used by the Apache Pekko Connectors Kafka connector uses SLF4J, as well.
@@dependency [Maven,sbt,Gradle] {
- symbol=AkkaVersion
+ symbol=PekkoVersion
value="$akka.version$"
- group=com.typesafe.akka
+ group=org.apache.pekko
artifact=akka-slf4j_$scala.binary.version$
Review Comment:
`pekko-slf4j_$scala.binary.version$`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #35: use correct config names and replace Akka/Alpakka mentions
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/35#discussion_r1103633075
##########
docs/src/main/paradox/cluster-sharding.md:
##########
@@ -14,23 +14,23 @@ When partitions and shards are co-located together then there is less chance tha
## Dependency
@@dependency [Maven,sbt,Gradle] {
- group=com.typesafe.akka
- artifact=akka-stream-kafka-cluster-sharding_$scala.binary.version$
+ group=org.apache.pekko
+ artifact=pekko-stream-kafka-cluster-sharding_$scala.binary.version$
Review Comment:
fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org