You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/11/21 03:15:27 UTC
[GitHub] [spark] HeartSaVioR edited a comment on issue #26610:
[SPARK-29973][SS] Use nano time to avoid 'NaN'/'Infinity'
HeartSaVioR edited a comment on issue #26610: [SPARK-29973][SS] Use nano time to avoid 'NaN'/'Infinity'
URL: https://github.com/apache/spark/pull/26610#issuecomment-556899657
I tend to agree with @srowen as handle the case exceptionally given I'm not sure a micro-batch under 1ms is realistic in most of cases, but if we still want to calculate it "accurately", define the new local variable for nanoTime to calculate duration instead of changing existing local variable which is also used for representing wall-clock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org