You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Ash Berlin-Taylor (JIRA)" <ji...@apache.org> on 2018/08/23 12:20:00 UTC

[jira] [Resolved] (AIRFLOW-2867) Airflow Python Code not compatible to coding guidelines and standards

     [ https://issues.apache.org/jira/browse/AIRFLOW-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ash Berlin-Taylor resolved AIRFLOW-2867.
----------------------------------------
    Resolution: Fixed

> Airflow Python Code not compatible to coding guidelines and standards 
> ----------------------------------------------------------------------
>
>                 Key: AIRFLOW-2867
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2867
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> Some of the Airflow code doesn't conform to python coding guidelines and standards.
> The improvement I have analyzed are below:
> - Dictionary creation should be written by dictionary literal
> - Mutable default argument. Python’s default arguments are evaluated once when the function is defined, not each time the function is called (like it is in say, Ruby). This means that if you use a mutable default argument and mutate it, you will and have mutated that object for all future calls to the function as well.
> - Functions calling sets can be replaced by set literal 
> - Replace list literals
> - Some of the static methods haven't been set static
> - Redundant parentheses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)