[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead

[GitBox <gi...@apache.org>]

bsloane1650 commented on a change in pull request #225: Implement daf:lookAhead
URL: https://github.com/apache/incubator-daffodil/pull/225#discussion_r289993433
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala
 ##########
 @@ -1579,13 +1585,19 @@ case class FunctionCallExpression(functionQNameString: String, expressions: List
       case (RefQName(_, "logicalTypeValueInt", DFDL), args) =>
         FNZeroArgExpr(functionQNameString, functionQName,
           NodeInfo.Integer, NodeInfo.AnyAtomic, DFDLXLogicalTypeValueInt(_, _))
-          
+
       case (RefQName(_, "logicalTypeValueString", DFDL), args) =>
         FNZeroArgExpr(functionQNameString, functionQName,
           NodeInfo.String, NodeInfo.AnyAtomic, DFDLXLogicalTypeValueString(_, _))
 
       //End typeValueCalc related functions
 
+      case (RefQName(_, "lookAhead", DAF_APACHE), args) =>
+        FNTwoArgsExpr(functionQNameString, functionQName, args,
+          NodeInfo.NonNegativeInteger, NodeInfo.UnsignedInt, NodeInfo.UnsignedInt, DFDLXLookAhead(_))
 
 Review comment:
   Fixed. I also took the opportunity to rename in to DAFLookAhead.
   
   @mbeckerle  @jadams-tresys  You might want to re-review since I was missing the guts of the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services