crash when upgrading wc

[Stefan Küng <to...@gmail.com>]

Hi,

Again a post about some crash dumps that were sent for TSVN:

When upgrading a working copy, there's an abort() called here:
subversion\subversion\libsvn_wc\util.c, 300： 
(svn_uri_is_canonical(repos_url, pool) &&
  svn_relpath_is_canonical(path_in_repos) && SVN_IS_VALID_REVNUM(peg_rev))

problem in this case: the 'repos_url' looks like this:
https://xxx.xx.xxx.192:443/svn/

now, in 1.6.x this was a valid canonical url. In 1.7 however, having the 
port number in the url if it's the default port makes 
svn_uri_is_canonical() return FALSE.

Fine by me, but when upgrading, this should be handled much better than 
with an abort() call!

stacktrace attached.

crash dumps (26) available here:
https://www.crash-server.com/Problem.aspx?ClientID=tsvn&ProblemID=1170

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

RE: crash when upgrading wc

[Bert Huijben <be...@vmoo.com>]

> -----Original Message-----
> From: Stefan Küng [mailto:tortoisesvn@gmail.com]
> Sent: vrijdag 1 juni 2012 21:22
> To: Subversion Development
> Subject: crash when upgrading wc
> 
> Hi,
> 
> Again a post about some crash dumps that were sent for TSVN:
> 
> When upgrading a working copy, there's an abort() called here:
> subversion\subversion\libsvn_wc\util.c, 300：
> (svn_uri_is_canonical(repos_url, pool) &&
>   svn_relpath_is_canonical(path_in_repos) &&
> SVN_IS_VALID_REVNUM(peg_rev))
> 
> problem in this case: the 'repos_url' looks like this:
> https://xxx.xx.xxx.192:443/svn/
> 
> now, in 1.6.x this was a valid canonical url. In 1.7 however, having the
> port number in the url if it's the default port makes
> svn_uri_is_canonical() return FALSE.


Fixed in r1345482. Nominated for backport in r1345483.

Note that there are more upgrade related nominations, including a huge performance boost.

	Bert