You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by miguelaferreira <gi...@git.apache.org> on 2015/10/19 11:33:34 UTC
[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/947
Add MySQL connector dependency to developer profile
The most common way to run the management server while developing is to start up Jetty via maven. However, in a continuous integration pipeline it is best to actually deploy the WAR file in a tomcat instance to make the setup as close as possible to a production environment.
This PR adds the MySQL connector dependency to the maven developer profile in order to make it easier to deploy a WAR file in the context of a continuous integration pipeline.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/miguelaferreira/cloudstack add-mysql-to-developer-profile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/947.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #947
----
commit e9ab28f6a2de81d8596fdb4b8e6d4aa967acfe1a
Author: Miguel Ferreira <mi...@me.com>
Date: 2015-10-19T09:29:23Z
Add MySQL connector dependency to developer profile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/947#issuecomment-149170965
wasn't there an issue about the license of this connector some time back?
What's the current license ? is it ASF compliant ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/947#issuecomment-149172742
Indeed we cannot ship this dependency, however we can and have been using it in development. As long as we don't enable the developer profile when we build the artefacts of a release, the dependency won't be included.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/947#issuecomment-149201734
I've made two PRs (#946 and #947) that are actually interdependent, so I'll close both and make a new one that combines the two.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/947#issuecomment-149170612
@DaanHoogland automation, automation, automation ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira closed the pull request at:
https://github.com/apache/cloudstack/pull/947
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/947#issuecomment-149166994
LGTM, only visual, i will run it in the bubble but the queue is now grown over 10 PRs :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---