You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/11 08:55:26 UTC
[GitHub] [iotdb] Cpaulyz opened a new pull request, #6966: [IOTDB-4116] Merge SenderService and ReceiverService into SyncService
Cpaulyz opened a new pull request, #6966:
URL: https://github.com/apache/iotdb/pull/6966
Merge SenderService and ReceiverService into SyncService
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6966: [IOTDB-4116] Merge SenderService and ReceiverService into SyncService
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #6966:
URL: https://github.com/apache/iotdb/pull/6966#discussion_r944379510
##########
node-commons/src/main/java/org/apache/iotdb/commons/service/ServiceType.java:
##########
@@ -33,10 +33,10 @@ public enum ServiceType {
JVM_MEM_CONTROL_SERVICE("Memory Controller", ""),
AUTHORIZATION_SERVICE("Authorization ServerService", ""),
FILE_READER_MANAGER_SERVICE("File reader manager ServerService", ""),
- SYNC_SERVICE("SYNC ServerService", ""),
UPGRADE_SERVICE("UPGRADE DataService", ""),
SETTLE_SERVICE("SETTLE DataService", ""),
- SENDER_SERVICE("Sync Sender service", ""),
+ SYNC_RPC_SERVICE("SYNC RPC ServerService", ""),
+ SYNC_SERVICE("Sync service", ""),
Review Comment:
unity naming of SYNC and Sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #6966: [IOTDB-4116] Merge SenderService and ReceiverService into SyncService
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #6966:
URL: https://github.com/apache/iotdb/pull/6966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org