[GitHub] sdedic opened a new pull request #973: GraalJS parser JAR removed from distribution. Created convenience mod…

[GitBox <gi...@apache.org>]

sdedic opened a new pull request #973: GraalJS parser JAR removed from distribution. Created convenience mod…
URL: https://github.com/apache/incubator-netbeans/pull/973
 
 
   …ule to produce distribution NBM for non-Apache distributors.
   
   The purpose of this PR is to satisfy distribution restrictions of Apache while assuring NB users will get the javascript editing features.
   
   JS editing in NetBeans relies on code evolved from oracle JS parser (see http://hg.openjdk.java.net/graal/graal-js-parser). The code is licensed using `GPL with classpath exception` and must not be distributed in a convenience binary by Apache.
   
   At the same time, the license allows to distribute the parser's code for other parties. So I changed the original wrapper module to use the parser's JAR at compile time only; the JAR will not be copied to the build output. 
   Then, I provided an additional "convenience" module, which **is not part of any cluster or any NB build** which will produce a `NBM` that contais the JS parser code for distribution. 
   
   NetBeans "feature on demand" support was changed so that it knows that an additional module is required and will attempt to locate the module on Update Centers (namely plugin portal). That means that if the NBM for the convenience module appears on Plugin Portal, it will be downloaded during activation and JS support will start to work.
   
   During the course I also fixed some minor issues:
   
   - if update fetch fails with IOException, no error dialog will show, errors will be printed into the wizard panel
   - if the required "extra" module is not available, wizard will block activation procedure
   
   Since the JS module **is not on the Plugin Portal now**, I put a testing module to my personal webspace - for **testing** use http://bordel.klfree.net/~belgarat/nb/pp/catalog.xml as an additional update catalog

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists