[GitHub] [iceberg] liuxiaocs7 commented on a diff in pull request #7482: Hive: Remove deprecated AssertHelpers

["liuxiaocs7 (via GitHub)" <gi...@apache.org>]

liuxiaocs7 commented on code in PR #7482:
URL: https://github.com/apache/iceberg/pull/7482#discussion_r1182117457


##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveSchemaUtil.java:
##########
@@ -147,13 +147,12 @@ public void testSchemaConvertToIcebergSchemaForEveryPrimitiveType() {
   @Test
   public void testNotSupportedTypes() {
     for (FieldSchema notSupportedField : getNotSupportedFieldSchemas()) {
-      AssertHelpers.assertThrows(
-          "should throw exception",
-          IllegalArgumentException.class,
-          "Unsupported Hive type",
-          () -> {
-            HiveSchemaUtil.convert(Lists.newArrayList(Arrays.asList(notSupportedField)));
-          });
+      Assertions.assertThatThrownBy(
+              () -> {

Review Comment:
   make sense, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org