You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2009/06/19 16:55:08 UTC
svn commit: r786527 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Fri Jun 19 14:55:07 2009
New Revision: 786527
URL: http://svn.apache.org/viewvc?rev=786527&view=rev
Log:
Votes and a comment
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=786527&r1=786526&r2=786527&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jun 19 14:55:07 2009
@@ -239,7 +239,7 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47369.
http://svn.apache.org/viewvc?rev=784879&view=rev
- +1: fhanik
+ +1: fhanik, markt
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37794
@@ -254,11 +254,13 @@
http://svn.apache.org/viewvc?rev=785768&view=rev
http://svn.apache.org/viewvc?rev=785859&view=rev
+1: kkolinko
+ +1: markt - I don't like commenting out code - if it isn't needed just delete it
+ - This is fine for 6.0.x, for trunk 1.6 is the minimum
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47389
http://svn.apache.org/viewvc?rev=786124&view=rev
- +1: fhanik
+ +1: fhanik, markt
-1:
* Fix bug (revert commit)
@@ -277,7 +279,7 @@
if(log.isInfoEnabled())
log.info("Setting multihome multicast interface to:" +mcastBindAddress);
- +1: fhanik
+ +1: fhanik, markt
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38352
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r786527 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Konstantin Kolinko wrote:
> 2009/6/19 <ma...@apache.org>
>> http://svn.apache.org/viewvc?rev=785768&view=rev
>> http://svn.apache.org/viewvc?rev=785859&view=rev
>> +1: kkolinko
>> + +1: markt - I don't like commenting out code - if it isn't needed just delete it
>> + - This is fine for 6.0.x, for trunk 1.6 is the minimum
>> -1:
> O.K, understood.
>
> I will update trunk to default to 1.6, for both EmbeddedServletOptions and JspC.
Great. Thanks.
> It is funny, that compilerTargetVM value in JspC in 6.0 defaults to
> "1.4" (that differs from the one in EmbeddedServletOptions), but I do
> not feel it is worth to update it to "1.5" there. (The only reason I
> might see for that is to align the code with documentation).
If you get the time, I'd it just to be consistent.
Cheers,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r786527 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2009/6/19 <ma...@apache.org>
> http://svn.apache.org/viewvc?rev=785768&view=rev
> http://svn.apache.org/viewvc?rev=785859&view=rev
> +1: kkolinko
> + +1: markt - I don't like commenting out code - if it isn't needed just delete it
> + - This is fine for 6.0.x, for trunk 1.6 is the minimum
> -1:
O.K, understood.
I will update trunk to default to 1.6, for both EmbeddedServletOptions and JspC.
It is funny, that compilerTargetVM value in JspC in 6.0 defaults to
"1.4" (that differs from the one in EmbeddedServletOptions), but I do
not feel it is worth to update it to "1.5" there. (The only reason I
might see for that is to align the code with documentation).
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org