[GitHub] [arrow] pitrou commented on a diff in pull request #13317: ARROW-16610: [Python] Raise an error for conflicting options in pq.write_to_dataset

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #13317:
URL: https://github.com/apache/arrow/pull/13317#discussion_r892091050


##########
python/pyarrow/parquet/__init__.py:
##########
@@ -3110,6 +3111,33 @@ def file_visitor(written_file):
         else:
             use_legacy_dataset = False
 
+    # Check for conflicting kewords
+    msg_confl_0 = (
+        "The '{0}' argument is not supported by legecy_dataset={2}. "
+        "Use only '{1}' instead."
+    )
+    msg_confl_1 = (
+        "The '{1}' argument is not supported by legecy_dataset={2}. "
+        "Use only '{0}' instead."
+    )

Review Comment:
   Fix parameter name:
   ```suggestion
       msg_confl_0 = (
           "The '{0}' argument is not supported by use_legacy_dataset={2}. "
           "Use only '{1}' instead."
       )
       msg_confl_1 = (
           "The '{1}' argument is not supported by use_legacy_dataset={2}. "
           "Use only '{0}' instead."
       )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org