You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2026/07/08 10:12:01 UTC

[PR] fix(a11y): add aria-label to dependency-list remove icon [superset]

eschutho opened a new pull request, #41878:
URL: https://github.com/apache/superset/pull/41878

   ## Summary
   The per-row "remove dependency" icon in the native filter dependency list (`DependencyList.tsx`'s `Row` component) had an `onClick` handler but no accessible name. `BaseIcon`'s auto-generated fallback label ("delete") is generic and doesn't tell a screen reader user which item will be removed or from what list.
   
   - **WCAG 2.1 SC 4.1.2 (Name, Role, Value) β€” Level A**
   - Adds `aria-label={t('Remove dependency')}` to the `DeleteFilter` icon in `superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx`
   - Behavior is unchanged β€” purely additive `aria-label`, no visual or functional change
   - Single call site of this icon in the file (confirmed via grep)
   
   ## Test plan
   - [ ] Open a dashboard's native filter config modal, enable "Values are dependent on other filters" on a filter with 2+ dependency candidates
   - [ ] Tab to the delete icon next to a dependency row with a screen reader running (VoiceOver/NVDA) and verify it announces "Remove dependency, button" instead of the generic "delete, button"
   - [ ] Confirm clicking the icon still removes the row as before (no behavior change)
   
   πŸ€– Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(a11y): add aria-label to dependency-list remove icon [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41878:
URL: https://github.com/apache/superset/pull/41878#issuecomment-4913829329

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41878?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.68%. Comparing base ([`3b1abf8`](https://app.codecov.io/gh/apache/superset/commit/3b1abf8260812960a8a8307f8a77e3f0e19831fe?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7b1993`](https://app.codecov.io/gh/apache/superset/commit/e7b19933e0f8f50a5db3d134aba74ea6ff48eec8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/41878?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rsConfigModal/FiltersConfigForm/DependencyList.tsx](https://app.codecov.io/gh/apache/superset/pull/41878?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2FnativeFilters%2FFiltersConfigModal%2FFiltersConfigForm%2FDependencyList.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlcGVuZGVuY3lMaXN0LnRzeA==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/41878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #41878   +/-   ##
   =======================================
     Coverage   64.68%   64.68%           
   =======================================
     Files        2702     2702           
     Lines      150192   150192           
     Branches    34585    34585           
   =======================================
     Hits        97145    97145           
     Misses      51258    51258           
     Partials     1789     1789           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/41878/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/41878/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.80% <0.00%> (ΓΈ)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41878?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(a11y): add aria-label to dependency-list remove icon [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #41878:
URL: https://github.com/apache/superset/pull/41878


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(a11y): add aria-label to dependency-list remove icon [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41878:
URL: https://github.com/apache/superset/pull/41878#issuecomment-4913720336

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org