[jira] [Commented] (AVRO-2694) Simplify Comparison Check in Resolver

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070264#comment-17070264 ] 

ASF subversion and git services commented on AVRO-2694:
-------------------------------------------------------

Commit 40622368863c19f9b103927b85af9dd65d18aedb in avro's branch refs/heads/master from belugabehr
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=4062236 ]

AVRO-2694: Simplify Comparison Check in Resolver (#774)

* AVRO-2694: Simplify Comparison Check in Resolver

* Revert minor refactor to lessen patch size

Co-authored-by: David Mollitor <dm...@apache.org>

> Simplify Comparison Check in Resolver
> -------------------------------------
>
>                 Key: AVRO-2694
>                 URL: https://issues.apache.org/jira/browse/AVRO-2694
>             Project: Apache Avro
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>
> For example:
> {code:java|title=Resolver.java}
>     case ENUM: {
>       final List<String> ws = write.getEnumSymbols();
>       final List<String> rs = read.getEnumSymbols();
>       if (ws.size() != rs.size()) {
>         return false;
>       }
>       int i = 0;
>       for (; i < ws.size(); i++) {
>         if (!ws.get(i).equals(rs.get(i))) {
>           break;
>         }
>       }
>       return i == ws.size();
>     }
> {code}
> This can just be replaced with {{ws.equals(ra)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)