You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Anahide Tchertchian <at...@nuxeo.com> on 2007/04/25 17:35:20 UTC
client id problem
Hi,
I noticed that trinidad components client ids are not set up correctly
when used inside a naming container that redefines its children client ids.
I believe this could be fixed applying the following changes, which is
not very visible as the default implementation returns getClientId when
calling getContainerClientId.
$ svn di
./src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
Index:
src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
===================================================================
---
src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
(revision 532384)
+++
src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
(working copy)
@@ -270,7 +270,7 @@
{
if (containerComponent instanceof NamingContainer)
{
- clientId = (containerComponent.getClientId(context) +
+ clientId = (containerComponent.getContainerClientId(context) +
NamingContainer.SEPARATOR_CHAR +
clientId);
break;
Do you think this could be made available for the next version?
Thanks,
--
Anahide Tchertchian, Nuxeo
Mail: at@nuxeo.com - Tel: +33 (0)1 40 33 79 87
http://www.nuxeo.com - http://www.nuxeo.org
Re: client id problem
Posted by Anahide Tchertchian <at...@nuxeo.com>.
Adam Winer a écrit :
> On 4/30/07, Anahide Tchertchian <at...@nuxeo.com> wrote:
>> Hi,
>> This is on the 1.1 trunk.
>
> There is no UIComponent.getContainerClientId() method
> in JSF 1.1. It was added in 1.2, and I'm pretty sure our
> 1.2 code properly calls it. The trunk is strictly 1.1. So
> I don't think you've found a bug.
I didn't know about that, sorry for the noise.
>> I'd be happy to test the 1.2 branch if I could find a maven repository
>> for it :)
>
> You have to build it yourself, I'm afraid. Ongoing problems
> with continuum have prevented us from putting it in a maven
> repository.
The 1.2 code does call it, I'll try it out.
Thanks for the info,
anahide.
Re: client id problem
Posted by Adam Winer <aw...@gmail.com>.
On 4/30/07, Anahide Tchertchian <at...@nuxeo.com> wrote:
> Hi,
> This is on the 1.1 trunk.
There is no UIComponent.getContainerClientId() method
in JSF 1.1. It was added in 1.2, and I'm pretty sure our
1.2 code properly calls it. The trunk is strictly 1.1. So
I don't think you've found a bug.
> I'd be happy to test the 1.2 branch if I could find a maven repository
> for it :)
You have to build it yourself, I'm afraid. Ongoing problems
with continuum have prevented us from putting it in a maven
repository.
-- Adam
> Adam Winer a écrit :
> > Is this on the 1.2 branch or the 1.1 trunk?
> >
> > -- Adam
> >
> >
> > On 4/25/07, Anahide Tchertchian <at...@nuxeo.com> wrote:
> >> Hi,
> >>
> >> I noticed that trinidad components client ids are not set up correctly
> >> when used inside a naming container that redefines its children client
> >> ids.
> >>
> >> I believe this could be fixed applying the following changes, which is
> >> not very visible as the default implementation returns getClientId when
> >> calling getContainerClientId.
> >>
> >> $ svn di
> >> ./src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> >>
> >> Index:
> >> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> >> ===================================================================
> >> ---
> >> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> >> (revision 532384)
> >> +++
> >> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> >> (working copy)
> >> @@ -270,7 +270,7 @@
> >> {
> >> if (containerComponent instanceof NamingContainer)
> >> {
> >> - clientId = (containerComponent.getClientId(context) +
> >> + clientId = (containerComponent.getContainerClientId(context) +
> >> NamingContainer.SEPARATOR_CHAR +
> >> clientId);
> >> break;
> >>
> >>
> >>
> >> Do you think this could be made available for the next version?
> >> Thanks,
> >>
> >> --
> >> Anahide Tchertchian, Nuxeo
> >> Mail: at@nuxeo.com - Tel: +33 (0)1 40 33 79 87
> >> http://www.nuxeo.com - http://www.nuxeo.org
> >>
> >
>
Re: client id problem
Posted by Anahide Tchertchian <at...@nuxeo.com>.
Hi,
This is on the 1.1 trunk.
I'd be happy to test the 1.2 branch if I could find a maven repository
for it :)
Thanks,
anahide.
Adam Winer a écrit :
> Is this on the 1.2 branch or the 1.1 trunk?
>
> -- Adam
>
>
> On 4/25/07, Anahide Tchertchian <at...@nuxeo.com> wrote:
>> Hi,
>>
>> I noticed that trinidad components client ids are not set up correctly
>> when used inside a naming container that redefines its children client
>> ids.
>>
>> I believe this could be fixed applying the following changes, which is
>> not very visible as the default implementation returns getClientId when
>> calling getContainerClientId.
>>
>> $ svn di
>> ./src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
>>
>> Index:
>> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
>> ===================================================================
>> ---
>> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
>> (revision 532384)
>> +++
>> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
>> (working copy)
>> @@ -270,7 +270,7 @@
>> {
>> if (containerComponent instanceof NamingContainer)
>> {
>> - clientId = (containerComponent.getClientId(context) +
>> + clientId = (containerComponent.getContainerClientId(context) +
>> NamingContainer.SEPARATOR_CHAR +
>> clientId);
>> break;
>>
>>
>>
>> Do you think this could be made available for the next version?
>> Thanks,
>>
>> --
>> Anahide Tchertchian, Nuxeo
>> Mail: at@nuxeo.com - Tel: +33 (0)1 40 33 79 87
>> http://www.nuxeo.com - http://www.nuxeo.org
>>
>
Re: client id problem
Posted by Adam Winer <aw...@gmail.com>.
Is this on the 1.2 branch or the 1.1 trunk?
-- Adam
On 4/25/07, Anahide Tchertchian <at...@nuxeo.com> wrote:
> Hi,
>
> I noticed that trinidad components client ids are not set up correctly
> when used inside a naming container that redefines its children client ids.
>
> I believe this could be fixed applying the following changes, which is
> not very visible as the default implementation returns getClientId when
> calling getContainerClientId.
>
> $ svn di
> ./src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> Index:
> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> ===================================================================
> ---
> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> (revision 532384)
> +++
> src/main/java/org/apache/myfaces/trinidad/component/UIXComponentBase.java
> (working copy)
> @@ -270,7 +270,7 @@
> {
> if (containerComponent instanceof NamingContainer)
> {
> - clientId = (containerComponent.getClientId(context) +
> + clientId = (containerComponent.getContainerClientId(context) +
> NamingContainer.SEPARATOR_CHAR +
> clientId);
> break;
>
>
>
> Do you think this could be made available for the next version?
> Thanks,
>
> --
> Anahide Tchertchian, Nuxeo
> Mail: at@nuxeo.com - Tel: +33 (0)1 40 33 79 87
> http://www.nuxeo.com - http://www.nuxeo.org
>