You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/10/18 13:23:03 UTC

[GitHub] [kafka] OmniaGM commented on pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on PR #12577:
URL: https://github.com/apache/kafka/pull/12577#issuecomment-1282380207

   > The `MirrorMakerConfigTest` tests the config part, but there's nothing that proves that the configured ForwardingAdmin is actually used when creating topics, ACLs etc. That might not be difficult to do as an integration test.
   
   I added an integration test called `MirrorConnectorsWithCustomForwardingAdminIntegrationTest` that test MM2 with `FakeForwardingAdminWithLocalMetadata` that stores the resource metadata in `FakeLocalMetadataStore` . Still working on testing ACLs ,however, it has been tricky to set up `EmbeddedConnectCluster` with `kafka.security.authorizer.AclAuthorizer`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org