You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Xiangrui Meng (JIRA)" <ji...@apache.org> on 2015/05/05 05:44:05 UTC

[jira] [Comment Edited] (SPARK-7047) Model parent should be Optional

    [ https://issues.apache.org/jira/browse/SPARK-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527856#comment-14527856 ] 

Xiangrui Meng edited comment on SPARK-7047 at 5/5/15 3:43 AM:
--------------------------------------------------------------

I think it should be sufficient to use `null`. Adding `hasParent` sounds good to me. We can also mark `parent` transient so it doesn't get serialized.


was (Author: mengxr):
I think it should be sufficient to use `null`. Adding `hasParent` sounds good to me.

> Model parent should be Optional
> -------------------------------
>
>                 Key: SPARK-7047
>                 URL: https://issues.apache.org/jira/browse/SPARK-7047
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 1.4.0
>            Reporter: Joseph K. Bradley
>            Assignee: Joseph K. Bradley
>            Priority: Minor
>
> Ensembles' component Models have no parents.  Instead of making those values null, we should make them Options.
> For Python, "None" is probably the correct equivalent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org