You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/02/27 20:03:06 UTC

[jira] [Commented] (SOLR-6847) LeaderInitiatedRecoveryThread compares wrong replica's state with lirState

    [ https://issues.apache.org/jira/browse/SOLR-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340617#comment-14340617 ] 

ASF subversion and git services commented on SOLR-6847:
-------------------------------------------------------

Commit 1662797 from [~steve_rowe] in branch 'dev/branches/lucene_solr_4_10'
[ https://svn.apache.org/r1662797 ]

SOLR-6847: LeaderInitiatedRecoveryThread compares wrong replica's state with lirState (merged branch_5x r1653880)

> LeaderInitiatedRecoveryThread compares wrong replica's state with lirState
> --------------------------------------------------------------------------
>
>                 Key: SOLR-6847
>                 URL: https://issues.apache.org/jira/browse/SOLR-6847
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.10.2
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Steve Rowe
>            Priority: Minor
>             Fix For: 4.10.4, 5.0, Trunk
>
>         Attachments: SOLR-6847.patch
>
>
> LeaderInitiatedRecoveryThread looks at a random replica to figure out if it should re-publish LIR state to "down". It does however publish the LIR state for the correct replica.
> The bug has always been there. The thread used ZkStateReader.getReplicaProps method with the coreName to find the correct replica. However, the coreName parameter in getReplicaProps was un-used and I removed it in SOLR-6240 but I didn't find and fix this bug then.
> The possible side-effects of this bug would be that we may be republish LIR state multiple times and/or in rare cases, cause double 'requestrecovery' to be executed on a replica.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org