[GitHub] weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration

[GitBox <gi...@apache.org>]

weichao666 commented on a change in pull request #613: [SCB-416]For load balance rule configurations, we need provider service level configuration
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/613#discussion_r175434451
 
 

 ##########
 File path: handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/Configuration.java
 ##########
 @@ -101,10 +101,11 @@ public String getRuleStrategyName(String microservice) {
         PROP_ROOT + PROP_RULE_STRATEGY_NAME);
   }
 
-  public int getSessionTimeoutInSeconds() {
+  public int getSessionTimeoutInSeconds(String microservice) {
     final int defaultValue = 30;
     // do not support MicroService level now
 
 Review comment:
   this annotation can be deleted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services