[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3583: ARTEMIS-3285 potential duplicate messages with LVQ + non-destructive

[GitBox <gi...@apache.org>]

jbertram commented on a change in pull request #3583:
URL: https://github.com/apache/activemq-artemis/pull/3583#discussion_r633554319



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LastValueQueue.java
##########
@@ -259,6 +251,8 @@ public QueueConfiguration getQueueConfiguration() {
    private void replaceLVQMessage(MessageReference ref, HolderReference hr) {
       MessageReference oldRef = hr.getReference();
 
+//      logger.info("Replacing " + oldRef + " with " + ref);

Review comment:
       fixed

##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -133,7 +133,7 @@
    protected static final int CRITICAL_CONSUMER = 3;
    protected static final int CRITICAL_CHECK_DEPAGE = 4;
 
-   private static final Logger logger = Logger.getLogger(QueueImpl.class);
+   protected static final Logger logger = Logger.getLogger(QueueImpl.class);

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org