[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3691: Some best-practices updates to the kickstart script

[GitBox <gi...@apache.org>]

ocket8888 opened a new pull request #3691: Some best-practices updates to the kickstart script
URL: https://github.com/apache/trafficcontrol/pull/3691
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR obsoletes #3503
   This PR makes some best-practices updates to the script responsible for generating the "network line" for kickstart ISO creation. Puts parenthesis around `print` statement args, better implementation of `str.format` and `str.join`, replaces a check for identity equality with the proper check for value equality, removed an unused variable, checking for presence of a member of a `set`/`dict` with `in`/`not in` instead of deprecated methods and/or weird argument nesting, etc.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Generate an ISO through a Traffic Ops instance that has the new version of the script, verify that it comes out correctly. The script has no tests, but you could also just check the output using Docker or a VM.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services