You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/09 20:12:26 UTC

[GitHub] sxjscience commented on a change in pull request #10025: Language model with Google's billion words dataset

sxjscience commented on a change in pull request #10025: Language model with Google's billion words dataset
URL: https://github.com/apache/incubator-mxnet/pull/10025#discussion_r173555975
 
 

 ##########
 File path: python/mxnet/gluon/contrib/rnn/rnn_cell.py
 ##########
 @@ -181,3 +181,126 @@ def unroll(self, length, inputs, begin_state=None, layout='NTC', merge_outputs=N
         outputs, _, _, _ = _format_sequence(length, outputs, layout, merge_outputs)
 
         return outputs, states
+
+
+class LSTMPCell(HybridRecurrentCell):
 
 Review comment:
   Can this be implemented as a ModifierCell? The implementation should be similar as ZoneOut.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services