[GitHub] [gobblin] homatthew commented on a diff in pull request #3643: [GOBBLIN-1786] Support Other Catalog Types for Iceberg Distcp

["homatthew (via GitHub)" <gi...@apache.org>]

homatthew commented on code in PR #3643:
URL: https://github.com/apache/gobblin/pull/3643#discussion_r1105049395


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergHiveCatalog.java:
##########
@@ -17,22 +17,54 @@
 
 package org.apache.gobblin.data.management.copy.iceberg;
 
-import lombok.AllArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
-
+import org.apache.iceberg.catalog.Catalog;
 import org.apache.iceberg.catalog.TableIdentifier;
 import org.apache.iceberg.hive.HiveCatalog;
 
+import lombok.extern.slf4j.Slf4j;
+
 
 /**
  * Hive-Metastore-based {@link IcebergCatalog}.
  */
 @Slf4j
-@AllArgsConstructor
 public class IcebergHiveCatalog implements IcebergCatalog {
+
+  /**
+   * Ensures pairing between {@link IcebergCatalog} and its implementation type i.e. {@link HiveCatalog} in this case.
+   * Unfortunately, {@link org.apache.iceberg.BaseMetastoreCatalog}.newTableOps is protected.
+   * Hence it necessitates this abtraction to define and access {@link IcebergTable}

Review Comment:
   nit: abtraction to abstraction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org