You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@quickstep.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/17 02:39:05 UTC
[jira] [Commented] (QUICKSTEP-6) Decimal: Fixed precision number type.

    [ https://issues.apache.org/jira/browse/QUICKSTEP-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335254#comment-15335254 ] 

ASF GitHub Bot commented on QUICKSTEP-6:
----------------------------------------

GitHub user hakanmemisoglu opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/37

    QUICKSTEP-6: Decimal type

    This request adds the simple Decimal type. The type does not accept any precision and scale argument for now. It takes default values 18 for precision and 2 for scale. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep decimal-type

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit 5aa559310b017f03e9ef648980f47198ba2e6e9c
Author: Hakan Memisoglu <ha...@apache.org>
Date:   2016-05-31T18:14:42Z

    New type for fixed precision number: Decimal.

commit d71599fd124d9ddaf97150b52c7e701e4bcd121b
Author: Hakan Memisoglu <ha...@apache.org>
Date:   2016-06-14T15:09:25Z

    New changes.

commit 400d268b9d28e331707cc58094b9f0decc415d5c
Author: Hakan Memisoglu <ha...@apache.org>
Date:   2016-06-15T18:16:18Z

    Make scale fixed to 10^2.

commit 4358b6eddd63016f665f0774833ce1d0b81cbee5
Author: Hakan Memisoglu <ha...@apache.org>
Date:   2016-06-15T21:23:24Z

    Introduced comparator functors for Decimal type.

commit 6b11fe0c214fc3d3d849f0916ba67f40fb37ffdd
Author: Hakan Memisoglu <ha...@apache.org>
Date:   2016-06-16T17:03:13Z

    Fixed bug where the wrong operator is used.

----


> Decimal: Fixed precision number type.
> -------------------------------------
>
>                 Key: QUICKSTEP-6
>                 URL: https://issues.apache.org/jira/browse/QUICKSTEP-6
>             Project: Apache Quickstep
>          Issue Type: New Feature
>          Components: Expressions, Parser, Types
>            Reporter: Hakan Memisoglu
>            Assignee: Hakan Memisoglu
>            Priority: Minor
>              Labels: quickstep-type
>
> Right now, Quickstep is doing operations only on floating point numbers when it requires non-integer numbers. However, TPCH requires only 2 digits after point. For that reason, we need to add a new type which stores its data as an integer data but interprets it as a fixed precision number.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)