You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/23 19:15:25 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #8889:
Test running CI against postgres instead of sqlite
willbarrett opened a new pull request #8889: Test running CI against postgres instead of sqlite
URL: https://github.com/apache/incubator-superset/pull/8889
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8889: Test
running CI against postgres instead of sqlite
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8889: Test running CI against postgres instead of sqlite
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-570327508
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8889?src=pr&el=h1) Report
> Merging [#8889](https://codecov.io/gh/apache/incubator-superset/pull/8889?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/191aca1fb01b797dae21657021d8fcd1e836c40a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8889?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8889 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 359 359
Lines 11333 11333
Branches 2787 2787
=======================================
Hits 6684 6684
Misses 4471 4471
Partials 178 178
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8889?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8889?src=pr&el=footer). Last update [191aca1...1ffa2fc](https://codecov.io/gh/apache/incubator-superset/pull/8889?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #8889: Remove
SQLite from CI (Implementation of SIP-33)
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #8889: Remove SQLite from CI (Implementation of SIP-33)
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-596234601
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #8889: Remove
SQLite from CI (Implementation of SIP-33)
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #8889: Remove SQLite from CI (Implementation of SIP-33)
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-572190208
Agreed @mistercrunch - this is still in draft state, there's more to do here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch edited a comment on issue #8889:
Remove SQLite from CI (Implementation of SIP-33)
Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on issue #8889: Remove SQLite from CI (Implementation of SIP-33)
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-572189122
I think we should error or at least warn on startup if the connection string starts with `sqllite`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8889: Remove
SQLite from CI (Implementation of SIP-33)
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8889: Remove SQLite from CI (Implementation of SIP-33)
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-572189673
Oh also I just checked and the default connection string in `config.py` is still `sqlite://`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8889: Remove
SQLite from CI (Implementation of SIP-33)
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #8889: Remove SQLite from CI (Implementation of SIP-33)
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-572189122
I wonder if we should error or warn on startup if the connection string starts with `sqllite`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #8889: Remove
SQLite from CI (Implementation of SIP-33)
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #8889: Remove SQLite from CI (Implementation of SIP-33)
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-596622509
bump
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8889: Test
running CI against postgres instead of sqlite
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8889: Test running CI against postgres instead of sqlite
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-569251124
@willbarrett I think you need to remove the `py36-sqlite` entry from `.travis.yml`: https://github.com/apache/incubator-superset/blob/master/.travis.yml#L82-L86
Other than that, LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #8889: Remove SQLite from CI (Implementation of SIP-33)
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #8889:
URL: https://github.com/apache/incubator-superset/pull/8889#issuecomment-626084875
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org