You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/10/10 23:18:06 UTC
[kudu-CR] KUDU-1261 control the maximum number of elements in an array
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23527
Change subject: KUDU-1261 control the maximum number of elements in an array
......................................................................
KUDU-1261 control the maximum number of elements in an array
This patch introduces a new --array_cell_max_elem_num runtime flag
to control the maximum number of array elements that can be written
into a Kudu table when ingesting data via RPC. Corresponding unit
tests scenarios are added as well.
Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
---
M src/kudu/common/array_cell_view.h
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.cc
3 files changed, 193 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/23527/1
--
To view, visit http://gerrit.cloudera.org:8080/23527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Gerrit-Change-Number: 23527
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-1261 control the maximum number of elements in an array
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23527 )
Change subject: KUDU-1261 control the maximum number of elements in an array
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1969/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Gerrit-Change-Number: 23527
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Oct 2025 00:45:06 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 control the maximum number of elements in an array
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23527 )
Change subject: KUDU-1261 control the maximum number of elements in an array
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Gerrit-Change-Number: 23527
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Oct 2025 23:42:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 control the maximum number of elements in an array
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23527 )
Change subject: KUDU-1261 control the maximum number of elements in an array
......................................................................
Patch Set 1: Verified+1
unrelated failures of known flaky tests (DEBUG, TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/23527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Gerrit-Change-Number: 23527
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Oct 2025 00:58:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 control the maximum number of elements in an array
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23527 )
Change subject: KUDU-1261 control the maximum number of elements in an array
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1969/
--
To view, visit http://gerrit.cloudera.org:8080/23527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Gerrit-Change-Number: 23527
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 10 Oct 2025 23:18:14 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 control the maximum number of elements in an array
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23527 )
Change subject: KUDU-1261 control the maximum number of elements in an array
......................................................................
KUDU-1261 control the maximum number of elements in an array
This patch introduces a new --array_cell_max_elem_num runtime flag
to control the maximum number of array elements that can be written
into a Kudu table when ingesting data via RPC. Corresponding unit
tests scenarios are added as well.
Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Reviewed-on: http://gerrit.cloudera.org:8080/23527
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/common/array_cell_view.h
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.cc
3 files changed, 193 insertions(+), 1 deletion(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Gerrit-Change-Number: 23527
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1261 control the maximum number of elements in an array
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-1261 control the maximum number of elements in an array
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I63c0f9bd09723c15b2666fe5f5e683f8c85cf3a7
Gerrit-Change-Number: 23527
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>