[GitHub] mistercrunch commented on issue #4358: [druid] fix bug around handling NULLs

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #4358: [druid] fix bug around handling NULLs
URL: https://github.com/apache/incubator-superset/pull/4358#issuecomment-363491420
 
 
   Note that `get_fillna_for_columns` assumes that the dataframe's column names are bound to table column names and related types. While this is generally the case, this is not enforced, and the bug could show up again if a string column in a dataframe is not named after a database column. 
   
   Viz like the Sankey may use specific columns as a source but rename dataframe columns to `source` and `target` for instance. In this case the current logic would fail at identifying the df columns as strings and the mixed type issue may re-appear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services