You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/10/02 06:22:30 UTC

[GitHub] spark pull request #22596: [SPARK-25576][BUILD][BRANCH-2.2] Fix lint failure

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22596#discussion_r221835152
  
    --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java ---
    @@ -63,7 +63,6 @@ public void basicTest() {
         checkBasic("hello", 5); // 5 * 1 byte chars
         checkBasic("大 千 世 界", 7);
         checkBasic("︽﹋％", 3); // 3 * 3 bytes chars
    -    checkBasic("\uD83E\uDD19", 1); // 4 bytes char
    --- End diff --
    
    We should not remove test coverage.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org