[jira] Commented: (QPID-2678) Qpid Shutdown OSGI plugin

["Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894396#action_12894396 ] 

Robbie Gemmell commented on QPID-2678:
--------------------------------------

The use of system.out.println() should be removed.

Why make a new ScheduledThreadPoolExecutor at every call of the shutdown(delay) method? I would change it to an instance variable I think. Also, given that it is simply going to shut down the JVM when it runs the first scheduled task it probably only needs 1 thread instead of 3.

It doesnt seem like the build.xml file should be overriding the bundle task? There is no .bnd file to be processed for the module and there is a specific manifest provided anyway.



> Qpid Shutdown OSGI plugin
> -------------------------
>
>                 Key: QPID-2678
>                 URL: https://issues.apache.org/jira/browse/QPID-2678
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: 0.7
>            Reporter: Sorin Suciu
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch
>
>
> Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for  testing purposes. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org