You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/07/15 06:09:28 UTC

[GitHub] [sling-org-apache-sling-feature-extension-apiregions] actinium15 commented on pull request #7: SLING-0 Reporting warning for extraneous (unexported) API packages…

actinium15 commented on pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/7#issuecomment-658566041


   hi @bosschaert, @cziegeler 
   
   I raised this PR with the understanding (incorrect, as I've been guided to understand now) that extraneous API packages in a feature-model are 'harmless', and thus a warning seems to be a better level to report it.
   
   The usecase here being that it should be possible to turn off the errors for "extraneous APIs in a region" for CI runs for individual repositories. At times the said individual repositories themselves don't constitute the final deliverable, but only contribute to it. We need the ability to ignore such API region validation errors to support API refactoring without resorting to splitting the changeset (which makes reviewing much harder).
   
   As such, adding the ability to configure analyzer severity [SLING-8940](https://issues.apache.org/jira/browse/SLING-8940) alongwith being able to control it via a user-property should be helpful to address my concern.
   
   I'll make a note of this in the JIRA and close this PR. Sorry for the noise.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org