You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Thomas Zub (Jira)" <ji...@apache.org> on 2022/03/23 14:12:00 UTC

[jira] [Created] (MNG-7439) Make fields of CliRequest protected

Thomas Zub created MNG-7439:
-------------------------------

             Summary: Make fields of CliRequest protected
                 Key: MNG-7439
                 URL: https://issues.apache.org/jira/browse/MNG-7439
             Project: Maven
          Issue Type: Improvement
          Components: Command Line, Embedding
    Affects Versions: 3.8.5
            Reporter: Thomas Zub


Hi,

currently the fields of 
{code:java}
org.apache.maven.cli.CliRequest {code}
have the default access modifier. As no setters are provided, custom modifications to e.g. multiModuleProjectDirectory can not be made without e.g. reflection or change of the system properties.

As an implementation of CliRequest with bean properties (private fields, getters and setters) would be possibly a breaking change, I suggest to make the fields protected to enable proper subclassing for custom modifications.

I would appreciate to make a PR if needed/wanted.

Kind regards
Thomas



--
This message was sent by Atlassian Jira
(v8.20.1#820001)