[GitHub] [pulsar] AnonHxy commented on a diff in pull request #18037: [fix][broker]consumer backlog eviction policy should not reset read position for consumer

[GitBox <gi...@apache.org>]

AnonHxy commented on code in PR #18037:
URL: https://github.com/apache/pulsar/pull/18037#discussion_r995350735


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java:
##########
@@ -210,22 +210,29 @@ private void dropBacklogForTimeLimit(PersistentTopic persistentTopic, BacklogQuo
             Long currentMillis = ((ManagedLedgerImpl) persistentTopic.getManagedLedger()).getClock().millis();
             ManagedLedgerImpl mLedger = (ManagedLedgerImpl) persistentTopic.getManagedLedger();
             try {
-                for (;;) {
+                for (; ; ) {
                     ManagedCursor slowestConsumer = mLedger.getSlowestConsumer();
                     Position oldestPosition = slowestConsumer.getMarkDeletedPosition();
+                    if (log.isDebugEnabled()) {
+                        log.debug("[{}] slowest consumer mark delete position is [{}], read position is [{}]",
+                                slowestConsumer.getName(), oldestPosition.toString(),

Review Comment:
   There is no need call `toString`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org