You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/10 06:16:35 UTC
[GitHub] [pulsar] lhotari opened a new pull request #11994: [Broker] Cleanup: remove unnecessary boxing
lhotari opened a new pull request #11994:
URL: https://github.com/apache/pulsar/pull/11994
### Motivation
When checking the latest merged commits in master branch, I noticed that the cleanup made in #11975 didn't cover all variables.
### Modifications
- remove unnecessary boxing for 2 variables
- `sourceBundle.partitions` is a `long[]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11994: [Broker] Cleanup: remove unnecessary boxing
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11994:
URL: https://github.com/apache/pulsar/pull/11994#issuecomment-916677173
> I searched the code, and there are many places where this situation occurs, such as:
> `PoliciesUtil#getBundles`
+1
btw. In Errorprone there is a check for finding these, https://errorprone.info/bugpattern/UnnecessaryBoxedVariable . Perhaps running that for the whole code base at once could be useful. The maven build for pulsar contains configuration for Errorprone. SpotBugs might have a similar check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #11994: [Broker] Cleanup: remove unnecessary boxing
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #11994:
URL: https://github.com/apache/pulsar/pull/11994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11994: [Broker] Cleanup: remove unnecessary boxing
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11994:
URL: https://github.com/apache/pulsar/pull/11994#issuecomment-917209866
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org