You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2015/10/30 02:06:44 UTC
[GitHub] cordova-plugin-device-motion pull request: CB-9369 Return error wh...
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/38
CB-9369 Return error when accelerometer not available
skip/pending tests when accel not available, use getters for properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-plugin-device-motion CB-9369
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device-motion/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 6b636a7d92b4b869b027f8377ebbd9b6dacf9a4d
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-10-30T00:56:40Z
Return error when accelerometer not available, skip/pending tests when accel not available, use getters for properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9369 Return error wh...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/38#issuecomment-152372394
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9369 Return error wh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-motion/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org