You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/21 04:33:40 UTC
Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common
definitions file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/
-----------------------------------------------------------
Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3434
https://issues.apache.org/jira/browse/MESOS-3434
Repository: mesos
Description
-------
This was originally part of this review[1] by haosdent. It was split out
and moved into the root folder by hausdorff, because we will later reuse
it to build other third-party libraries on Windows that are not only in
libprocess, and hence it belongs outside of the commits that touch
libprocess.
But, the code is essentially haosdent's, so the credit should go to him.
[1] Original review: https://reviews.apache.org/r/37273
Diffs
-----
CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
cmake/Common.cmake PRE-CREATION
Diff: https://reviews.apache.org/r/38538/diff/
Testing
-------
Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
* OS X 10.10
* Windows 10
* Ubuntu 14.04.2
Thanks,
Alex Clemmer
Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to
common definitions file.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/#review99720
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Sept. 21, 2015, 2:33 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38538/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 2:33 a.m.)
>
>
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3434
> https://issues.apache.org/jira/browse/MESOS-3434
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This was originally part of this review[1] by haosdent. It was split out
> and moved into the root folder by hausdorff, because we will later reuse
> it to build other third-party libraries on Windows that are not only in
> libprocess, and hence it belongs outside of the commits that touch
> libprocess.
>
> But, the code is essentially haosdent's, so the credit should go to him.
>
> [1] Original review: https://reviews.apache.org/r/37273
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
> cmake/Common.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38538/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to
common definitions file.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/#review100726
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 21, 2015, 2:33 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38538/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 2:33 a.m.)
>
>
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3434
> https://issues.apache.org/jira/browse/MESOS-3434
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This was originally part of this review[1] by haosdent. It was split out
> and moved into the root folder by hausdorff, because we will later reuse
> it to build other third-party libraries on Windows that are not only in
> libprocess, and hence it belongs outside of the commits that touch
> libprocess.
>
> But, the code is essentially haosdent's, so the credit should go to him.
>
> [1] Original review: https://reviews.apache.org/r/37273
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
> cmake/Common.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38538/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to
common definitions file.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/#review99785
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Sept. 20, 2015, 7:33 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38538/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 7:33 p.m.)
>
>
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3434
> https://issues.apache.org/jira/browse/MESOS-3434
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This was originally part of this review[1] by haosdent. It was split out
> and moved into the root folder by hausdorff, because we will later reuse
> it to build other third-party libraries on Windows that are not only in
> libprocess, and hence it belongs outside of the commits that touch
> libprocess.
>
> But, the code is essentially haosdent's, so the credit should go to him.
>
> [1] Original review: https://reviews.apache.org/r/37273
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
> cmake/Common.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38538/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to
common definitions file.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/#review100595
-----------------------------------------------------------
LGTM.
- Artem Harutyunyan
On Sept. 20, 2015, 7:33 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38538/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 7:33 p.m.)
>
>
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3434
> https://issues.apache.org/jira/browse/MESOS-3434
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This was originally part of this review[1] by haosdent. It was split out
> and moved into the root folder by hausdorff, because we will later reuse
> it to build other third-party libraries on Windows that are not only in
> libprocess, and hence it belongs outside of the commits that touch
> libprocess.
>
> But, the code is essentially haosdent's, so the credit should go to him.
>
> [1] Original review: https://reviews.apache.org/r/37273
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
> cmake/Common.cmake PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38538/diff/
>
>
> Testing
> -------
>
> Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:
>
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
>
>
> Thanks,
>
> Alex Clemmer
>
>