[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1139: [flink] Support watermark change by altering table

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1139:
URL: https://github.com/apache/incubator-paimon/pull/1139#discussion_r1191932396


##########
docs/content/how-to/altering-tables.md:
##########
@@ -409,3 +409,51 @@ ALTER TABLE my_table ALTER COLUMN col_a SET DATA TYPE DOUBLE;
 {{< /tab >}}
 
 {{< /tabs >}}
+
+## Adding watermark
+
+The following SQL adds a watermark with strategy `ts - INTERVAL '1' HOUR` on column `ts` which is marked as event time attribute of table `my_table`.
+
+{{< tabs "add-watermark" >}}
+
+{{< tab "Flink" >}}
+
+```sql
+ALTER TABLE my_table ADD WATERMARK FOR ts AS ts - INTERVAL '1' HOUR

Review Comment:
   Can you also add an example: `add computed column` here? Sometimes watermark is closely related to computed column.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org