You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/02/02 11:34:35 UTC
[jira] [Commented] (CB-8394) Globalization plugin tests failing on
windows and wp8 platforms
[ https://issues.apache.org/jira/browse/CB-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301125#comment-14301125 ]
ASF GitHub Bot commented on CB-8394:
------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/35
CB-8394 - included windows and wp8 quirks into tests
This is a fix for https://issues.apache.org/jira/browse/CB-8394
The idea is to split failing tests into two parts (two `it`s):
First part checks the functionality that is supported on all platforms,
Second part checks the functionality that is unsupported on wp8 and windows and is marked pending on these two platforms.
This way we can mark tests pending and still check the functionality that is supported.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-globalization windows-test-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-globalization/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit 82091b4354517dfc7366b2864af32d6681ba366f
Author: alsorokin <al...@akvelon.com>
Date: 2015-02-02T10:27:12Z
CB-8394 - included windows and wp8 quirks into tests
----
> Globalization plugin tests failing on windows and wp8 platforms
> ---------------------------------------------------------------
>
> Key: CB-8394
> URL: https://issues.apache.org/jira/browse/CB-8394
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Globalization
> Reporter: Alexander Sorokin
>
> Mobile-spec tests for globalization plugin are failing on wp8 and windows because these platforms only partially support getNumberPattern and getCurrencyPattern methods.
> We need to include windows and wp8 quirks into tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org