You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2015/11/06 20:42:15 UTC

Review Request 40033: Prevent start failure in LocatorLauncherRemoteJUnitTest.testStartDeletesStaleControlFiles

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40033/
-----------------------------------------------------------

Review request for geode and Darrel Schneider.


Bugs: GEODE-530
    https://issues.apache.org/jira/browse/GEODE-530


Repository: geode


Description
-------

Rename timeout constant to indicate that it's for process startup. Increase it from 5 minutes to 10 minutes.


Diffs
-----

  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherJUnitTestCase.java 5e79bef 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java 071afd4 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherJUnitTestCase.java 31300dd 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java ac091f6 
  gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5833bd4 

Diff: https://reviews.apache.org/r/40033/diff/


Testing
-------

LocatorLauncherRemoteJUnitTest, LauncherTestSuite, test, integrationTest


Thanks,

Kirk Lund


Re: Review Request 40033: Prevent start failure in LocatorLauncherRemoteJUnitTest.testStartDeletesStaleControlFiles

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40033/#review105500
-----------------------------------------------------------

Ship it!


Ship It!

- Darrel Schneider


On Nov. 6, 2015, 11:42 a.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40033/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 11:42 a.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Bugs: GEODE-530
>     https://issues.apache.org/jira/browse/GEODE-530
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Rename timeout constant to indicate that it's for process startup. Increase it from 5 minutes to 10 minutes.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLauncherJUnitTestCase.java 5e79bef 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractLocatorLauncherJUnitTestCase.java 071afd4 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/AbstractServerLauncherJUnitTestCase.java 31300dd 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java ac091f6 
>   gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java 5833bd4 
> 
> Diff: https://reviews.apache.org/r/40033/diff/
> 
> 
> Testing
> -------
> 
> LocatorLauncherRemoteJUnitTest, LauncherTestSuite, test, integrationTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>