You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/23 12:59:11 UTC
[PR] Fix openGauss official case-insensitive collation metadata [shardingsphere]
terrymanu opened a new pull request, #39224:
URL: https://github.com/apache/shardingsphere/pull/39224
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix openGauss official case-insensitive collation metadata [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39224:
URL: https://github.com/apache/shardingsphere/pull/39224#issuecomment-5058802437
### Summary
**Review Result: Mergeable**
Reason: The latest PR repairs the loader’s root cause within its declared code scope, and the result is code-scope only; CI was not reviewed by request.
### Evidence
- The original trigger was the hard-coded `caseSensitive = true`. The PR fixes that path by projecting `collation_schema` and `collation_name`, then mapping only official `pg_catalog` collations.
- The six-name allowlist matches the official openGauss B/D-mode collation documentation, which defines these `_ci` collations and their case-insensitive suffix semantics: [openGauss character set and collation documentation](https://docs.opengauss.org/zh/docs/6.0.0-RC1/docs/SQLReference/%E5%AD%97%E7%AC%A6%E9%9B%86%E4%B8%8E%E5%AD%97%E7%AC%A6%E5%BA%8F.html).
- The upstream `information_schema.columns` view exposes `collation_schema` from `pg_namespace` and `collation_name` from `pg_collation`; the catalog entries place the six official collations in `PGNSP` (`pg_catalog`): [information_schema source](https://gitee.com/opengauss/openGauss-server/blob/master/src/common/backend/catalog/information_schema.sql), [pg_collation catalog](https://gitee.com/opengauss/openGauss-server/blob/master/src/include/catalog/pg_collation.h).
- `database/connector/dialect/opengauss/src/main/java/org/apache/shardingsphere/database/connector/opengauss/metadata/data/loader/OpenGaussMetaDataLoader.java:51-56,183-184` keeps custom schemas, unknown `_ci` names, `_bin`, and null/default metadata on the conservative `true` path.
- `database/connector/dialect/opengauss/src/test/java/org/apache/shardingsphere/database/connector/opengauss/metadata/data/loader/OpenGaussMetaDataLoaderTest.java:191-224` covers all six official names and the relevant negative boundaries through the public `load` path.
- Complete collation behavior such as PAD SPACE, locale/UCA/pinyin ordering, expression-level `COLLATE`, and downstream equivalence semantics is not implemented by this PR; that is consistent with the metadata-only scope and is not a merge blocker.
### Review Details
- Review Focus: Code Correctness Review; CI not reviewed by request.
- Reviewed Scope: PR head `20c90560d2b3886a5297ba0af578f833a2916a63`, base `master@78865882e539133778f397f8a3e2ee8fec2613f6`, merge-base `78865882e539133778f397f8a3e2ee8fec2613f6`. The local two-file scope matches GitHub `/pulls/39224/files`.
- Not Reviewed Scope: GitHub Actions/check-runs, real openGauss integration across multiple server versions, and full collation-consumer semantics.
- Verification: `./mvnw -pl database/connector/dialect/opengauss -Dtest=OpenGaussMetaDataLoaderTest test -Pcheck -T1C` passed with 10 tests and zero failures.
- Release Note / User Docs: Not required; this is an internal metadata-accuracy fix with no configuration, API, migration, or upgrade procedure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix openGauss official case-insensitive collation metadata [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39224:
URL: https://github.com/apache/shardingsphere/pull/39224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org