You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/08/19 12:58:38 UTC

[Bug 56869] New: Add code to collect the maximum number of backend connections

https://issues.apache.org/bugzilla/show_bug.cgi?id=56869

            Bug ID: 56869
           Summary: Add code to collect the maximum number of backend
                    connections
           Product: Tomcat Connectors
           Version: 1.2.40
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: mod_jk
          Assignee: dev@tomcat.apache.org
          Reporter: knobi@knobisoft.de

Created attachment 31929
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31929&action=edit
Patch to add MxCon

In addition to display the "Current number of backend connections" on the
jkmanager status page, it is useful to see the "Maximum number of backend
connections" as well.

The attached patch against r1618835 does that. It requires an additional "int"
field in structure "jk_shm_ajp_worker". As I am not familiar enough with the
code, it may as well need adaption of the value of JK_SHM_SLOT_SIZE. This
should be checked by someone in the know.

Thanks
Martin

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56869] Add code to collect the maximum number of backend connections

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56869

--- Comment #1 from Martin Knoblauch <kn...@knobisoft.de> ---
One thought: if this metric is deemed useful, the question is whether it should
be reset to zero whenever the worker is reset via the gui. The current patch
does not do it. Personally I have no real preference. both ways seem to make
sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56869] Add code to collect the maximum number of backend connections

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56869

--- Comment #2 from Rainer Jung <ra...@kippdata.de> ---
Thanks for your contribution.

I have applied this patch with very minor changes in r1647150, it will be part
of mod_jk 1.2.41.

A change to JK_SHM_SLOT_SIZE was not needed, there was still enough space left.
I have added general checking code whether JK_SHM_SLOT_SIZE is big enough
to the startup. Determining the optimal JK_SHM_SLOT_SIZE during configure would
be better, but we do not use configure on all platforms.

Regards,

Rainer

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56869] Add code to collect the maximum number of backend connections

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56869

Rainer Jung <ra...@kippdata.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56869] Add code to collect the maximum number of backend connections

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56869

--- Comment #3 from Rainer Jung <ra...@kippdata.de> ---
I added a reset of the max connected count to the status worker in the general
statistics reset functions. See r1649784.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org