You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/08/09 16:26:32 UTC

[GitHub] zeppelin pull request #3121: [ZEPPELIN-3694] Dynamically change scheduler th...

GitHub user egorklimov opened a pull request:

    https://github.com/apache/zeppelin/pull/3121

    [ZEPPELIN-3694] Dynamically change scheduler thread pool size using REST API

    ### What is this PR for?
    
    It would be nice if we could change thread pool size for scheduler dynamically.
    
    ### Using this feature:
    1. Create file `quartz.properties` from default file located in `org.quartz` and add them to `conf` directory
    2. In `quartz.properties` set `org.quartz.threadPool.class` to `org.apache.zeppelin.scheduler.dynamic_pool.impl.ExecutorServiceThreadPool`
    
    Otherwise you will get message "Thread pool size is constant."
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    * issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3694
    
    ### How should this be tested?
    * Tests added
    * Tested manually
    
    ### Screenshots
    Firstly when thread pool size equals `1` notes wait for each other, but when scheduler thread pool size changed to `2` they start to work in parallel.
    
    ![cron mp4](https://user-images.githubusercontent.com/6136993/43912013-afe69940-9c09-11e8-8dd8-12d2026f03ef.gif)
    
    
    ### Questions:
    * Does the licenses files need update?  No
    I added sources of [quartz-dynamic-pool](https://github.com/epiresdasilva/quartz-dynamic-pool) developed by @epiresdasilva, because this repo isn't included in http://mvnrepository.com
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, REST API docs updated


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17795

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3121
    
----
commit bc10033ad1986b1565a2e593eb94060c90699429
Author: egorklimov <kl...@...>
Date:   2018-08-03T10:24:24Z

    Quartz-dynamic pool added

commit f34186a764e85913fccf47b2325a2deea43322ae
Author: egorklimov <kl...@...>
Date:   2018-08-08T14:12:09Z

    API updated

commit c441127779f087ee72f57e21af549ce2cdf0e2bd
Author: egorklimov <kl...@...>
Date:   2018-08-08T17:56:44Z

    Add scheduler functions to REST API

commit 431a87126c2ad382d0c6d4d91da3ce1730e7cfa8
Author: egorklimov <kl...@...>
Date:   2018-08-09T10:24:04Z

    Tests and docs added
    bugs fixed

commit 8c99472889835470fbf706c8e6a04602f20f4ae5
Author: egorklimov <kl...@...>
Date:   2018-08-09T11:16:41Z

    License updated

commit 3e86962df360d4e0c1e2dc733d4983ede6c2f2f0
Author: egorklimov <kl...@...>
Date:   2018-08-09T15:44:13Z

    docs updated

commit 58f41b43e2b60938d6e4acdf3119e0c4768ec20e
Author: egorklimov <kl...@...>
Date:   2018-08-09T16:15:47Z

    docs fixed

----


---

[GitHub] zeppelin issue #3121: [ZEPPELIN-3694] Dynamically change scheduler thread po...

Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:

    https://github.com/apache/zeppelin/pull/3121
  
    CI is green: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/422979013


---

[GitHub] zeppelin pull request #3121: [ZEPPELIN-3694] Dynamically change scheduler th...

Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov closed the pull request at:

    https://github.com/apache/zeppelin/pull/3121


---

[GitHub] zeppelin issue #3121: [ZEPPELIN-3694] Dynamically change scheduler thread po...

Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:

    https://github.com/apache/zeppelin/pull/3121
  
    CI is green: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/436625044


---

[GitHub] zeppelin issue #3121: [ZEPPELIN-3694] Dynamically change scheduler thread po...

Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:

    https://github.com/apache/zeppelin/pull/3121
  
    CI pass https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/414155839


---

[GitHub] zeppelin issue #3121: [ZEPPELIN-3694] Dynamically change scheduler thread po...

Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:

    https://github.com/apache/zeppelin/pull/3121
  
    CI pass: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/415384640


---

[GitHub] zeppelin issue #3121: [ZEPPELIN-3694] Dynamically change scheduler thread po...

Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:

    https://github.com/apache/zeppelin/pull/3121
  
    CI pass: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416307550


---